CORS-4142: ensure lbType is NLB when dual-stack is configured #10256
Conversation
This commit adds validation to ensure platform.aws.lbType is NLB when dual-stack networking is configured on AWS. AWS does not support dual-stack for Classic load balancers. Additionally, if lbType is left empty and ipFamily is set to dual-stack values, the installer will default lbType to NLB.
openshift-ci-robot
added
the
jira/valid-reference
|
@tthvo: This pull request references CORS-4142 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label platform/aws |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cc @yunjiang29 |
tthvo
force-pushed
the
CORS-4142-lbType
branch
from
d112c2c to
d1f15d1
Compare
|
@tthvo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
This PR adds validation to ensure
platform.aws.lbTypeisNLBwhen dual-stack networking is configured on AWS. AWS does not support dual-stack for Classic load balancers.Additionally, if
lbTypeis left empty andipFamilyis set to dual-stack values, the installer will defaultlbTypetoNLB. I guess this is a nice user experience so that they have to remember configuring load balancer type.This is part 1 of CORS-4142. Part 2 will focus on populating ingress and
defaultingress-controller manifests.