Skip to content

Conversation

@tthvo
Copy link
Member

@tthvo tthvo commented Jan 27, 2026

This PR adds NodeIPFamilies configuration to AWS cloud provider config when dual-stack networking is enabled. The cloud provider now sets the appropriate IP family ordering (ipv4/ipv6 or ipv6/ipv4) based on the install config's ipFamily setting. Tested and extracted from #9930.

For dual-stack IPv4 primary clusters, NodeIPFamilies is set to:

[Global]
NodeIPFamilies=ipv4
NodeIPFamilies=ipv6

For dual-stack IPv6 primary clusters, NodeIPFamilies is set to:

[Global]
NodeIPFamilies=ipv6
NodeIPFamilies=ipv4

Single-stack IPv4 clusters continue to use the minimal config with an empty Global section.

[Global]

Note: The installer lays down the correct format. However, CCCMO modifies the format of the NodeIPFamilies entries incorrectly in-cluster. The PR openshift/cluster-cloud-controller-manager-operator#426 will fix that.

tthvo added 2 commits January 26, 2026 18:31
Add NodeIPFamilies configuration to AWS cloud provider config
when dual-stack networking is enabled. The cloud provider now
sets the appropriate IP family ordering (ipv4/ipv6 or ipv6/ipv4)
based on the install config's IPFamily setting.

For dual-stack IPv4 primary clusters, NodeIPFamilies is set to:

NodeIPFamilies=ipv4
NodeIPFamilies=ipv6

For dual-stack IPv6 primary clusters, NodeIPFamilies is set to:

NodeIPFamilies=ipv6
NodeIPFamilies=ipv4

Single-stack IPv4 clusters continue to use the minimal config with an
empty Global section.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 27, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 27, 2026

@tthvo: This pull request references CORS-4328 which is a valid jira issue.

Details

In response to this:

This PR adds NodeIPFamilies configuration to AWS cloud provider config when dual-stack networking is enabled. The cloud provider now sets the appropriate IP family ordering (ipv4/ipv6 or ipv6/ipv4) based on the install config's ipFamily setting. Tested and extracted from #9930.

For dual-stack IPv4 primary clusters, NodeIPFamilies is set to:

[Global]
NodeIPFamilies=ipv4
NodeIPFamilies=ipv6

For dual-stack IPv6 primary clusters, NodeIPFamilies is set to:

[Global]
NodeIPFamilies=ipv6
NodeIPFamilies=ipv4

Single-stack IPv4 clusters continue to use the minimal config with an empty Global section.

[Global]

Note: The installer lays down the correct format. However, CCCMO modifies the format of the NodeIPFamilies entries incorrectly in-cluster. The PR openshift/cluster-cloud-controller-manager-operator#426 will fix that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stephenfin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tthvo
Copy link
Member Author

tthvo commented Jan 27, 2026

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2026

@tthvo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants