CORS-4055, CORS-4078: migrate ELB/ELBv2 API calls to AWS SDK v2 #10258
Conversation
The commit is an incremental step to migrate AWS API calls to AWS SDK
v2. This focuses on ELB/ELBv2 clients in the pkg/asset and dependent
pkg(s).
The ELB and ELBv2 clients now use SDK v2 with custom endpoint resolvers
that maintain backwards compatibility with SDK v1 service endpoint
configurations. Special handling is included for the fact that SDK v1 used
the same endpoint identifier ("elasticloadbalancing") for both ELB classic
and ELBv2, while SDK v2 uses distinct service IDs.
openshift-ci-robot
added
the
jira/valid-reference
|
@tthvo: This pull request references CORS-4055 which is a valid jira issue. This pull request references CORS-4078 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cc @barbacbd @yunjiang29 We can see the inspiration for the backwards compact logic here: kubernetes-sigs/cluster-api-provider-aws#5680 |
|
/retest |
|
Additional note: ELBv2 is actually the only client used during the install phase to describe load balancer and get its canonical zone for creating Route53 alias record. I also included a common ELB (classic) client construct, which should be used by the destroy code (later refactor PR). |
|
/label platform/aws |
|
/test artifacts-images |
|
@tthvo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
The PR is an incremental step to migrate AWS API calls to AWS SDK v2. This focuses on ELB/ELBv2 clients in the pkg/asset and dependent pkg(s).
Note The ELB and ELBv2 clients now use SDK v2 with custom endpoint resolvers that maintain backwards compatibility with SDK v1 service endpoint configurations. Special handling is included for the fact that SDK v1 used the same endpoint identifier ("elasticloadbalancing") for both ELB classic and ELBv2, while SDK v2 uses distinct service IDs.