Skip to content

Conversation

@tthvo
Copy link
Member

@tthvo tthvo commented Jan 28, 2026

The PR is an incremental step to migrate AWS API calls to AWS SDK v2. This only focuses on Route 53 clients in the pkg/asset and dependent pkg(s).

This PR contains quite a lot refactoring in order to follow the AWS SDK v2 client pattern.

tthvo added 2 commits January 27, 2026 20:34
The commit is an incremental step to migrate AWS API calls to AWS SDK v2.
This only focuses on Route53 clients in the pkg/asset and dependent pkg(s).
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 28, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 28, 2026

@tthvo: This pull request references CORS-4055 which is a valid jira issue.

Details

In response to this:

The PR is an incremental step to migrate AWS API calls to AWS SDK v2. This only focuses on Route 53 clients in the pkg/asset and dependent pkg(s).

This PR contains quite a lot refactoring in order to follow the AWS SDK v2 client pattern.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tthvo
Copy link
Member Author

tthvo commented Jan 28, 2026

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-openldap-mini-perm-f7

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-openldap-mini-perm-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4a5f5af0-fc03-11f0-867f-09e93b4dd687-0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rna-afk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tthvo
Copy link
Member Author

tthvo commented Jan 28, 2026

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 28, 2026
@tthvo
Copy link
Member Author

tthvo commented Jan 28, 2026

/label platform/aws

/cc @barbacbd @yunjiang29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. platform/aws tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants