OCPBUGS-37943: FIPS based ISO Boot support for s390x arch

[phani2898]

Summary

This PR introduces enhancements to the agentimage.go file, particularly focusing on appending kargs into the boot image itself where ignition is already embedded using the staging ISO boot image files. This is necessary for architecture like s390x where ignition and kargs lies in the same boot image (cdboot.img) unlike x86 where we have different boot files for booth.

It includes a decision making in the appendKargs function based on the CPU Architecture to call a newly added function EmbedKargsIntoBootImage in the isoeditor package of assisted-image-service for embedding kernel arguments into boot images where ignition content is also present

This decision making skips to call NewKargsReader function in-case of s390x architecture where the kargs details fetching and updating them into boot images are specific to x86, which is not relevant for s390x

Initially this PR is added to make decision for cpu arch: s390x only but this can be extended for other architectures which falls under same category of not being dependant on COREOS_KARGS_EMBED_AREA string to calculate kargs offsets and embed kargs & ignition into different boot files

Links

This PR dependant on the code changes that are done in assisted-image-service. Check out this PR for the same : openshift/assisted-image-service#472

Slack discussion : https://redhat-internal.slack.com/archives/C06A57N4WEM/p1745332383117689

[openshift-ci-robot]

@phani2898: An error was encountered searching for bug OCPBUGS-37943 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.

You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 403:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

Summary

This PR introduces enhancements to the agentimage.go file, particularly focusing on appending kargs into the boot image itself where ignition is already embedded using the staging ISO boot image files. This is necessary for architecture like s390x where ignition and kargs lies in the same boot image (cdboot.img) unlike x86 where we have different boot files for booth.

It includes a decision making in the appendKargs function based on the CPU Architecture to call a newly added function EmbedKargsIntoBootImage in the isoeditor package of assisted-image-service for embedding kernel arguments into boot images where ignition content is also present

This decision making skips to call NewKargsReader function in-case of s390x architecture where the kargs details fetching and updating them into boot images are specific to x86, which is not relevant for s390x

Initially this PR is added to make decision for cpu arch: s390x only but this can be extended for other architectures which falls under same category of not being dependant on COREOS_KARGS_EMBED_AREA string to calculate kargs offsets and embed kargs & ignition into different boot files

Links

This PR related with the code changes that are done in assisted-image-service. Check out this PR for the same : openshift/assisted-image-service#472

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bfournie for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/asset/agent/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@phani2898: An error was encountered searching for bug OCPBUGS-37943 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.

You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 403:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

Summary

This PR introduces enhancements to the agentimage.go file, particularly focusing on appending kargs into the boot image itself where ignition is already embedded using the staging ISO boot image files. This is necessary for architecture like s390x where ignition and kargs lies in the same boot image (cdboot.img) unlike x86 where we have different boot files for booth.

It includes a decision making in the appendKargs function based on the CPU Architecture to call a newly added function EmbedKargsIntoBootImage in the isoeditor package of assisted-image-service for embedding kernel arguments into boot images where ignition content is also present

This decision making skips to call NewKargsReader function in-case of s390x architecture where the kargs details fetching and updating them into boot images are specific to x86, which is not relevant for s390x

Initially this PR is added to make decision for cpu arch: s390x only but this can be extended for other architectures which falls under same category of not being dependant on COREOS_KARGS_EMBED_AREA string to calculate kargs offsets and embed kargs & ignition into different boot files

Links

This PR related with the code changes that are done in assisted-image-service. Check out this PR for the same : openshift/assisted-image-service#472

Slack discussion : https://redhat-internal.slack.com/archives/C06A57N4WEM/p1745332383117689

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@phani2898: An error was encountered searching for bug OCPBUGS-37943 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.

You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 403:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

Summary

This PR introduces enhancements to the agentimage.go file, particularly focusing on appending kargs into the boot image itself where ignition is already embedded using the staging ISO boot image files. This is necessary for architecture like s390x where ignition and kargs lies in the same boot image (cdboot.img) unlike x86 where we have different boot files for booth.

It includes a decision making in the appendKargs function based on the CPU Architecture to call a newly added function EmbedKargsIntoBootImage in the isoeditor package of assisted-image-service for embedding kernel arguments into boot images where ignition content is also present

This decision making skips to call NewKargsReader function in-case of s390x architecture where the kargs details fetching and updating them into boot images are specific to x86, which is not relevant for s390x

Initially this PR is added to make decision for cpu arch: s390x only but this can be extended for other architectures which falls under same category of not being dependant on COREOS_KARGS_EMBED_AREA string to calculate kargs offsets and embed kargs & ignition into different boot files

Links

This PR dependant on the code changes that are done in assisted-image-service. Check out this PR for the same : openshift/assisted-image-service#472

Slack discussion : https://redhat-internal.slack.com/archives/C06A57N4WEM/p1745332383117689

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@phani2898: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agent-4control-ipv4	f79a4e5	link	false	/test e2e-agent-4control-ipv4
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage	f79a4e5	link	false	/test e2e-agent-compact-ipv4-appliance-diskimage
ci/prow/golint	f79a4e5	link	true	/test golint
ci/prow/artifacts-images	f79a4e5	link	true	/test artifacts-images
ci/prow/govet	f79a4e5	link	true	/test govet
ci/prow/e2e-agent-ha-dualstack	f79a4e5	link	false	/test e2e-agent-ha-dualstack
ci/prow/images	f79a4e5	link	true	/test images
ci/prow/okd-scos-images	f79a4e5	link	true	/test okd-scos-images
ci/prow/e2e-agent-sno-ipv4-pxe	f79a4e5	link	false	/test e2e-agent-sno-ipv4-pxe
ci/prow/okd-scos-e2e-aws-ovn	f79a4e5	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/integration-tests-nodejoiner	f79a4e5	link	true	/test integration-tests-nodejoiner
ci/prow/e2e-agent-compact-ipv6-minimaliso	f79a4e5	link	false	/test e2e-agent-compact-ipv6-minimaliso
ci/prow/e2e-azure-ovn-resourcegroup	f79a4e5	link	false	/test e2e-azure-ovn-resourcegroup
ci/prow/e2e-vsphere-externallb-ovn	f79a4e5	link	false	/test e2e-vsphere-externallb-ovn
ci/prow/e2e-agent-5control-ipv4	f79a4e5	link	false	/test e2e-agent-5control-ipv4
ci/prow/e2e-agent-sno-ipv6	f79a4e5	link	false	/test e2e-agent-sno-ipv6
ci/prow/integration-tests	f79a4e5	link	true	/test integration-tests
ci/prow/e2e-agent-compact-ipv4-none-platform	f79a4e5	link	false	/test e2e-agent-compact-ipv4-none-platform
ci/prow/unit	f79a4e5	link	true	/test unit
ci/prow/e2e-vsphere-host-groups-ovn-techpreview	f79a4e5	link	false	/test e2e-vsphere-host-groups-ovn-techpreview
ci/prow/e2e-vsphere-ovn-multi-network	f79a4e5	link	false	/test e2e-vsphere-ovn-multi-network
ci/prow/e2e-vsphere-static-ovn	f79a4e5	link	false	/test e2e-vsphere-static-ovn
ci/prow/e2e-agent-compact-ipv4	f79a4e5	link	true	/test e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@phani2898: An error was encountered searching for bug OCPBUGS-37943 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.

You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 403:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

Summary

This PR introduces enhancements to the agentimage.go file, particularly focusing on appending kargs into the boot image itself where ignition is already embedded using the staging ISO boot image files. This is necessary for architecture like s390x where ignition and kargs lies in the same boot image (cdboot.img) unlike x86 where we have different boot files for booth.

It includes a decision making in the appendKargs function based on the CPU Architecture to call a newly added function EmbedKargsIntoBootImage in the isoeditor package of assisted-image-service for embedding kernel arguments into boot images where ignition content is also present

This decision making skips to call NewKargsReader function in-case of s390x architecture where the kargs details fetching and updating them into boot images are specific to x86, which is not relevant for s390x

Initially this PR is added to make decision for cpu arch: s390x only but this can be extended for other architectures which falls under same category of not being dependant on COREOS_KARGS_EMBED_AREA string to calculate kargs offsets and embed kargs & ignition into different boot files

Links

This PR dependant on the code changes that are done in assisted-image-service. Check out this PR for the same : openshift/assisted-image-service#472

Slack discussion : https://redhat-internal.slack.com/archives/C06A57N4WEM/p1745332383117689

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.