Allow manifest selection based on feature gates #2067
Conversation
|
@JoelSpeed: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
bertinatto
left a comment
bertinatto
left a comment
There was a problem hiding this comment.
I think it would be helpful to have a proof PR for this change. Other than that, I’ve reviewed the changes (with my limited knowledge in this area), and it LGTM. Leaving the final approval to the CVO team.
/approve
| // capability. This is necessary to allow updates to an OCP version containing newly defined capabilities. | ||
| func (m *Manifest) IncludeAllowUnknownCapabilities(excludeIdentifier *string, requiredFeatureSet *string, profile *string, | ||
| capabilities *configv1.ClusterVersionCapabilitiesStatus, overrides []configv1.ComponentOverride, allowUnknownCapabilities bool) error { | ||
| capabilities *configv1.ClusterVersionCapabilitiesStatus, overrides []configv1.ComponentOverride, enabledFeatureGates sets.Set[string], allowUnknownCapabilities bool) error { |
There was a problem hiding this comment.
Note to self: this is used here: https://github.com/openshift/cluster-version-operator/blob/d245c43ce077fe452771d9eee3af4ca57e79459b/lib/manifest/manifest.go#L46
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
2 participants
This will allow CVO to start including/excluding manifests based on the enabled feature gates, as opposed to currently where we only include based on the enabled feature set.
This means that we will need fewer simul-merge PRs where we merge a feature gate promotion but then have to adjust manifests to change their feature gating level.
The annotation itself is
release.openshift.io/feature-gatewhich takes a comma separated list of feature gates, each optionally prefix by-to indicate a negation (this gate must be disabled). The requirements are ANDed.