-
Notifications
You must be signed in to change notification settings - Fork 34
OLS-2335: Add support for pull secrets for BYOK images #1199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@syedriko: This pull request references OLS-2335 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
733455d to
0bf018d
Compare
0bf018d to
c11f807
Compare
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
c11f807 to
fd6f12b
Compare
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@syedriko: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
This commit adds an array of image pull secrets to the OLSConfig. These pull secrets contain authentication credentials for remote image registries and are used for pulling RAG BYOK images from image registries requiring authentication.
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing