modified MCP servers definition. Added Tool filtering config #1222
Conversation
| continue | ||
| } | ||
| // Use consistent path structure: /etc/mcp/headers/<secretName>/header | ||
| headerValue = path.Join(utils.MCPHeadersMountRoot, header.ValueFrom.SecretRef.Name, utils.MCPSECRETDATAPATH) |
There was a problem hiding this comment.
would it be better to let user configure which key in the secret is the header?
they may prefer host multiple header values in the same secret.
There was a problem hiding this comment.
Ideally yes, but can be more complex. I would preffer to keep it simple for now. Do not expect to have many MCP servers of this type
| .PHONY: manifests | ||
| manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects. | ||
| $(CONTROLLER_GEN) rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases | ||
| $(CONTROLLER_GEN) rbac:roleName=manager-role crd:allowDangerousTypes=true webhook paths="./..." output:crd:artifacts:config=config/crd/bases |
There was a problem hiding this comment.
lol which type is dangerous?
There was a problem hiding this comment.
I have no idea. This is generated
|
/lgtm looks good. |
openshift-ci
bot
added
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/lgtm |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@blublinsky: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Description
Type of change
Related Tickets & Documents
OLS-2275
Checklist before requesting a review
Testing