Skip to content

OCPBUGS-62875: images: test that creating an imagestream with --dry-run does not actually create the object #30403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liouk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-62875: images: test that creating an imagestream with --dry-run does not actually create the object #30403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions test/extended/images/dryrun.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@ package images

import (
"context"
"fmt"
"time"

g "github.com/onsi/ginkgo/v2"
o "github.com/onsi/gomega"

apierrors "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/util/wait"
admissionapi "k8s.io/pod-security-admission/api"

Expand Down Expand Up @@ -76,4 +78,26 @@ var _ = g.Describe("[sig-imageregistry] Image --dry-run", func() {
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(output).To(o.BeEmpty())
})

g.It("should not create resources [apigroup:image.openshift.io]", func() {
g.By("triggering create operation of imagestream with --dry-run=server")
err := oc.Run("create").Args("imagestream", "dryrun-test", "--dry-run=server").Execute()
o.Expect(err).NotTo(o.HaveOccurred())

// wait for 10s to make sure we'll not miss any resource created accidentally
err = wait.PollUntilContextTimeout(context.Background(), 1*time.Second, 10*time.Second, true, func(ctx context.Context) (bool, error) {
_, err := oc.Run("get").Args("imagestream", "dryrun-test", "-o", "jsonpath={.metadata.name}").Output()
if err == nil {
return false, fmt.Errorf("imagestream was created when it shouldn't have been")
}
return false, nil
})
// polling must timeout otherwise it means we found the object
o.Expect(err).To(o.Equal(context.DeadlineExceeded))

g.By("the test imagestream must not exist")
_, err = oc.Run("get").Args("imagestream", "dryrun-test", "-o", "jsonpath={.image.metadata.name}").Output()
o.Expect(err).To(o.HaveOccurred())
o.Expect(apierrors.IsNotFound(err)).To(o.BeTrue(), fmt.Sprintf("expected NotFound error, got: %v", err))
})
})