Skip to content

Conversation

@christophermancini
Copy link

@christophermancini christophermancini commented Dec 10, 2025

[SDCICD-1704] enhance Slack notifications with metadata and smart truncation

  • Added Cluster ID and Expiration timestamp to Slack notifications
  • Implemented smart log truncation: preserves first/last lines and extracts
    up to 3 [FAILED] blocks with 35 lines of context
  • Added automatic Prow job URL generation based on environment variables
  • Enhanced Slack client to support file uploads to threads using bot tokens
  • Added comprehensive unit tests and real-world Prow log fixtures
  • Cleaned up linting errors and improved integration test skip logic

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christophermancini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2025
@christophermancini christophermancini marked this pull request as ready for review January 8, 2026 21:20
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2026
@openshift-ci openshift-ci bot requested review from minlei98 and ritmun January 8, 2026 21:20
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2026
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2026
@christophermancini christophermancini force-pushed the cm/cluster-info branch 2 times, most recently from f6c412b to 4511f85 Compare January 8, 2026 22:33
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2026
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2026
@christophermancini christophermancini force-pushed the cm/cluster-info branch 2 times, most recently from 0ff3b4e to 508a98b Compare January 19, 2026 16:50
@christophermancini christophermancini changed the title [SDCICD-1704] add cluster id and expiration to message [SDCICD-1704] enhance Slack notifications with metadata and smart truncation Jan 19, 2026
@ritmun
Copy link
Contributor

ritmun commented Jan 22, 2026

Could you please post a link to a sample slack thread created from this code?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 22, 2026
…mart log extraction

This commit adds cluster info to notifications, implements a failure-aware
log truncation strategy, and enables rich file attachments via the Slack API.
Includes comprehensive unit tests and improved local test reliability.
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 22, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2026

@christophermancini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hypershift-pr-check c1b53ff link true /test hypershift-pr-check

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants