-
Notifications
You must be signed in to change notification settings - Fork 127
SDCICD-1717: update yaml file #3082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@varunraokadaparthi: This pull request references SDCICD-1717 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Co-authored-by: Ritu Mundhe <rmundhe@redhat.com>
christophermancini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christophermancini, varunraokadaparthi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@varunraokadaparthi: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Add support for configuring krkn-ai fitness function query and scenarios via viper config/environment variables. After the krkn-ai container runs in discover mode, the output YAML is automatically updated with user-specified values.
Changes
New Configuration Options
Added two new config keys to
KrknAIconfig:krknAI.fitnessQueryKRKN_FITNESS_QUERYkrknAI.scenariosKRKN_SCENARIOSYAML Update Logic
After
runKrknContainer()completes, a newupdateKrknConfig()function:krkn-ai.yamlfile from the shared directoryfitness_function.queryifKRKN_FITNESS_QUERYis setKRKN_SCENARIOSExample Usage
Set the fitness function query
export
KRKN_FITNESS_QUERY='sum(kube_pod_container_status_restarts_total)'Set scenarios to enable (comma-separated)
export
KRKN_SCENARIOS='pod_scenarios,container_scenarios,node_cpu_hog,node_memory_hog'pkg/common/config/config.go- AddedFitnessQueryandScenariosconfig keyspkg/krknai/krknai.go- AddedupdateKrknConfig()functionCo-authored-by: Cursor AI cursor@cursor.sh