-
Notifications
You must be signed in to change notification settings - Fork 127
SDCICD-1728 adding AGENTS.md with local test config examples #3086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
0daef49 to
2a62144
Compare
|
|
||
| ## What This Is | ||
| End-to-end testing framework for Managed services for OSD/ROSA. Provisions clusters, runs health checks, executes tests, and collects artifacts. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there could be some value for the agent reading this to have a simple description of how this project is used and to see the README.md for more in depth context.
E.g. "This project is used as part of CICD workflows to validate changes to OpenShift Operators within OSD/ROSA, like Prow nightly jobs"
This extra little context I think would help the agent make decisions faster about design or troubleshooting issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suggested description "This project is used as part of CICD workflows to validate changes to OpenShift Operators within OSD/ROSA, like Prow nightly jobs" is specific to one use case and doesn't represent all that osde2e supports fully. So I've updated the description slightly to include its applications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! It will give agents a bit more context to run off of without throwing too much at it.
christophermancini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added one comment but otherwise I think this looks good.
|
@ritmun: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
christophermancini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christophermancini, ritmun The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added AGENTS.md