[OCPERT-210] Add OpenShift Tests Extension (OTE) integration by using the automated migration OTE tool #705
Conversation
…d OTE migration tool
|
Need more testing |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| # Build extension binary | ||
| .PHONY: build | ||
| build: bindata | ||
| go build -o router ./cmd |
There was a problem hiding this comment.
we'd better to put the compiled binary file to ./bin/router-test
There was a problem hiding this comment.
I'm working on fixing this in single mode, but I have question about the compiled binary file in multi-mode, where we put it when there is no bin directory in target repo? Shall we create a bin directory or not?
There was a problem hiding this comment.
I think it's not a problem, we can create bin dir under root dir, the user can modify the make file if they want
| go build -o router ./cmd | ||
|
|
||
| # Run tests | ||
| .PHONY: test |
There was a problem hiding this comment.
Is this target useful, I don't think we have Golang test under this dir
|
|
||
| # Clean generated files | ||
| .PHONY: clean | ||
| clean: clean-bindata |
There was a problem hiding this comment.
the target dependency looks incorrect, here we only need to clean up all the binaries. bindata cleanup should be invoked in bindata target before compiling test templates
|
the changes in root Makefile is missed, i.e. compile router test extension in a builder stage, compress it with gzip and copy it to router image |
ming1013
changed the title
|
@ming1013: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Tested by:
$ tests-extension/router list | grep -F '"name": "[sig-' |wc -l
7742
Part of automated migration OTE tool log:
Migration Complete! 🎉
I've successfully migrated your router component to the OpenShift Tests
Extension (OTE) framework. Here's what was done:
What Was Created
A new tests-extension/ directory in your router repository containing:
openshift-tests-private/test/extended/testdata/router/
Key Features
tests)
Critical Fix Applied
I discovered and fixed a Ginkgo version incompatibility issue by adding the
OpenShift Ginkgo fork replace directive:
github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2
v2.6.1-0.20241205171354-8006f302fd12
Quick Start
cd tests-extension
Build the extension
make build
List all tests
./router list
Run tests
./router run
The complete migration summary with all details, troubleshooting tips, and
customization options is provided above. You're ready to integrate this into
your CI/CD pipeline!
Directory structure:
/home/minl/router/ # Working directory
└── tests-extension/ # Isolated test extension directory
├── cmd/
│ └── main.go # OTE entry point
├── test/
│ ├── e2e/ # Test files
│ │ └── *.go (23 files)
│ └── testdata/ # Testdata files
│ ├── bindata.go # Generated
│ └── fixtures.go # Wrapper functions
├── go.mod # Single module
├── go.sum
├── Makefile # Build targets
└── bindata.mk # Bindata generation