Skip to content

[release-4.15] OCPBUGS-51287: [Release-4.17]Kubeconfig loop #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
openshift-cherrypick-robot wants to merge 1 commit into from
Closed

[release-4.15] OCPBUGS-51287: [Release-4.17]Kubeconfig loop #347

openshift-cherrypick-robot wants to merge 1 commit into from

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Feb 25, 2025

This is an automated cherry-pick of #340

/assign bpickard22

@bpickard22
Kubeconfig loop
07b9c1d 
Creates functions to generate the kubeconfig and whereabouts conf
use these functions to check if the serviveAccount changes to regen the
kubeconfig if it expires

Change WHEREABOUTS_FLATFILE to WHEREABOUTS_CONF_FILE for clarity

Signed-off-by: Benjamin Pickard <bpickard@redhat.com>
(cherry picked from commit 27fd922)
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 25, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 25, 2025

@openshift-cherrypick-robot: Jira Issue OCPBUGS-50005 has been cloned as Jira Issue OCPBUGS-51287. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-51287: [Release-4.17]Kubeconfig loop

Details

In response to this:

This is an automated cherry-pick of #340

/assign bpickard22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-50005: [Release-4.17]Kubeconfig loop [release-4.15] OCPBUGS-51287: [Release-4.17]Kubeconfig loop Feb 25, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 25, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 25, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-51287, which is invalid:

  • expected dependent Jira Issue OCPBUGS-50005 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #340

/assign bpickard22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dougbtv
Copy link
Contributor

dougbtv commented Feb 25, 2025

/approve

@dougbtv
Copy link
Contributor

dougbtv commented Feb 25, 2025

/lgtm

@dougbtv
Copy link
Contributor

dougbtv commented Feb 25, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 25, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 07b9c1d link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@asood-rh
Copy link

asood-rh commented Feb 26, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 26, 2025
@bpickard22
Copy link
Contributor

bpickard22 commented May 8, 2025

/close

@openshift-ci openshift-ci bot closed this May 8, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2025

@bpickard22: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 8, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-51287. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

This is an automated cherry-pick of #340

/assign bpickard22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bpickard22
Copy link
Contributor

bpickard22 commented May 8, 2025

doesnt matter if we backport this since the script never gets ran in the whereabouts binary, we run it in CNO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dougbtv dougbtv Awaiting requested review from dougbtv dougbtv is a code owner

@bpickard22 bpickard22 Awaiting requested review from bpickard22

@s1061123 s1061123 Awaiting requested review from s1061123

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@bpickard22 bpickard22

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.