Fix sd-watchdog ping logic to ensure earlier ping once re-enabled #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit when pingEnabled is changed, we force a new sdNotify
to ensure a new starting point.
Previous issue example with sd watchdog 20s and pubsub timeout 11s
Jan 15 11:04:47.534780 node1 om[421482]: daemon: main: sd-watchdog: disable on missing pubsub heathcheck
Jan 15 11:04:59.939026 node1 om[421482]: daemon: main: sd-watchdog: enable on pubsub heathcheck
// a ping should have been sent here
Jan 15 11:05:02.689806 node1 systemd[1]: opensvc-server.service: Watchdog timeout (limit 20s)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.