Skip to content

Fix SubnetAlphaOut recycling in recycle_alpha.rs (# Issue #2274: Root Cause & Fix Analysis) #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dairus01 wants to merge 8 commits into
base: devnet-ready
Choose a base branch
from
+6 −0
Open

Fix SubnetAlphaOut recycling in recycle_alpha.rs (# Issue #2274: Root Cause & Fix Analysis) #2297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
30c7c53
Fix SubnetAlphaOut recycling in recycle_alpha.rs
Dairus01 Dec 16, 2025
1db8633
Fix: Use actual_alpha_decrease in recycle and revert manual SubnetAlp…
Dairus01 Dec 16, 2025
936f41f
chore: Update CI Rust toolchain to 1.89.0 to fix cargo-audit
Dairus01 Dec 16, 2025
a8e123b
Revert cargo-audit toolchain to stable per maintainer feedback
Dairus01 Dec 16, 2025
0119036
Revert recycle_subnet_alpha argument to 'amount' per maintainer review
Dairus01 Dec 16, 2025
0f4fcf2
Fix accounting: Decrement TotalStake in recycle_subnet_alpha and add …
Dairus01 Dec 16, 2025
05361b9
Remove unused burn_tokens_and_update_stake function
Dairus01 Dec 17, 2025
27c67c8
Fix E0277: Convert AlphaCurrency to u64 before casting to TaoCurrency…
Dairus01 Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pallets/subtensor/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2396,6 +2396,8 @@ pub mod pallet {
total_stake >= Self::get_stake_threshold()
}



/// Helper function to check if register is allowed
pub fn checked_allowed_register(netuid: NetUid) -> bool {
if netuid.is_root() {
Expand Down
4 changes: 4 additions & 0 deletions pallets/subtensor/src/staking/helpers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,10 @@ impl<T: Config> Pallet<T> {
SubnetAlphaOut::<T>::mutate(netuid, |total| {
*total = total.saturating_sub(amount);
});
// Keep TotalStake in sync
TotalStake::<T>::mutate(|total| {
*total = total.saturating_sub(amount.to_u64().into());
});
}

/// The function clears Alpha map in batches. Each run will check ALPHA_MAP_BATCH_SIZE
Expand Down