-
Notifications
You must be signed in to change notification settings - Fork 266
Fixing StakingHotkeys index #2300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devnet-ready
Are you sure you want to change the base?
Conversation
| let mut storage_writes: u64 = 0; | ||
|
|
||
| for ((hotkey, coldkey, _netuid), alpha) in Alpha::<T>::iter() { | ||
| if alpha == 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a read for Alpha, need update weight. Alpha is a big map, it is better to find other storage to find out missed (cold, hot) relation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @open-junius ! I added the forgotten weight. As for the Alfa map idea: I understand your concern but StakingHotkeys is literally index for Alfa map (please correct me if I'm wrong) and one of its goals is indeed to replace some costly calls to Alfa map. In this case using different map for (cold, hot) relation (like Owner map) doesn't make sense to me. Wdyt?
Description
Migration was introduced that adds missing coldkey<->hotkey pairs into StakingHotkeys index.
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.