feat: SHA-2 incremental hasher design

.github/workflows/extension-tests.cuda.yml

@@ -35,7 +35,7 @@ jobs:
       matrix:
         extensions: # group extensions on the same runner based on test time
           - "rv32im native"
-          - "keccak256 sha256 bigint algebra ecc pairing"
+          - "keccak256 sha2 bigint algebra ecc pairing"
     runs-on:
       - runs-on=${{ github.run_id }}-extension-tests-cuda-${{ github.run_attempt }}-${{ strategy.job-index }}/runner=${{ github.event_name == 'workflow_dispatch' && github.event.inputs.machine_type || 'test-gpu-nvidia/cpu=8+32' }}
 
@@ -57,8 +57,8 @@ jobs:
               - "extensions/native/**"
             keccak256:
               - "extensions/keccak256/**"
-            sha256:
-              - "extensions/sha256/**"
+            sha2:
+              - "extensions/sha2/**"
             bigint:
               - "extensions/bigint/**"
             algebra:

.github/workflows/extension-tests.yml

@@ -31,15 +31,15 @@ jobs:
           - { name: "rv32im", path: "rv32im", aot: false }
           - { name: "native", path: "native", aot: false }
           - { name: "keccak256", path: "keccak256", aot: false }
-          - { name: "sha256", path: "sha256", aot: false }
+          - { name: "sha2", path: "sha2", aot: false }
           - { name: "bigint", path: "bigint", aot: false }
           - { name: "algebra", path: "algebra", aot: false }
           - { name: "ecc", path: "ecc", aot: false }
           - { name: "pairing", path: "pairing", aot: false }
           - { name: "rv32im", path: "rv32im", aot: true }
           - { name: "native", path: "native", aot: true }
           - { name: "keccak256", path: "keccak256", aot: true }
-          - { name: "sha256", path: "sha256", aot: true }
+          - { name: "sha2", path: "sha2", aot: true }
           - { name: "bigint", path: "bigint", aot: true }
           - { name: "algebra", path: "algebra", aot: true }
           - { name: "ecc", path: "ecc", aot: true }

.github/workflows/guest-lib-tests.cuda.yml

@@ -52,7 +52,7 @@ jobs:
               - ".github/workflows/guest-lib-tests.cuda.yml"
               - "crates/sdk/guest/fib/**"
             sha2:
-              - "extensions/sha256/**"
+              - "extensions/sha2/**"
               - "guest-libs/sha2/**"
             keccak256:
               - "extensions/keccak256/**"

.github/workflows/primitives.yml

@@ -9,7 +9,7 @@ on:
     paths:
       - "crates/circuits/primitives/**"
       - "crates/circuits/poseidon2-air/**"
-      - "crates/circuits/sha256-air/**"
+      - "crates/circuits/sha2-air/**"
       - "crates/circuits/mod-builder/**"
       - "Cargo.toml"
       - ".github/workflows/primitives.yml"
@@ -65,13 +65,6 @@ jobs:
         run: |
           cargo nextest run ${{ env.NEXTEST_ARGS }}
 
-        # No gpu tests in these crates
-      - name: Run tests for sha256-air
-        if: ${{ !contains(matrix.platform.runner, 'gpu') }}
-        working-directory: crates/circuits/sha256-air
-        run: |
-          cargo nextest run ${{ env.NEXTEST_ARGS }}
-
       - name: Run tests for mod-builder
         if: ${{ !contains(matrix.platform.runner, 'gpu') }}
         working-directory: crates/circuits/mod-builder

Cargo.toml

@@ -51,9 +51,9 @@ members = [
     "extensions/keccak256/circuit",
     "extensions/keccak256/transpiler",
     "extensions/keccak256/guest",
-    "extensions/sha256/circuit",
-    "extensions/sha256/transpiler",
-    "extensions/sha256/guest",
+    "extensions/sha2/circuit",
+    "extensions/sha2/transpiler",
+    "extensions/sha2/guest",
     "extensions/ecc/circuit",
     "extensions/ecc/transpiler",
     "extensions/ecc/guest",
@@ -123,7 +123,7 @@ openvm-cuda-common = { git = "https://github.com/openvm-org/stark-backend.git",
 openvm-sdk = { path = "crates/sdk", default-features = false }
 openvm-mod-circuit-builder = { path = "crates/circuits/mod-builder", default-features = false }
 openvm-poseidon2-air = { path = "crates/circuits/poseidon2-air", default-features = false }
-openvm-sha256-air = { path = "crates/circuits/sha256-air", default-features = false }
+openvm-sha2-air = { path = "crates/circuits/sha2-air", default-features = false }
 openvm-circuit-primitives = { path = "crates/circuits/primitives", default-features = false }
 openvm-circuit-primitives-derive = { path = "crates/circuits/primitives/derive", default-features = false }
 openvm = { path = "crates/toolchain/openvm", default-features = false }
@@ -153,9 +153,9 @@ openvm-native-transpiler = { path = "extensions/native/transpiler", default-feat
 openvm-keccak256-circuit = { path = "extensions/keccak256/circuit", default-features = false }
 openvm-keccak256-transpiler = { path = "extensions/keccak256/transpiler", default-features = false }
 openvm-keccak256-guest = { path = "extensions/keccak256/guest", default-features = false }
-openvm-sha256-circuit = { path = "extensions/sha256/circuit", default-features = false }
-openvm-sha256-transpiler = { path = "extensions/sha256/transpiler", default-features = false }
-openvm-sha256-guest = { path = "extensions/sha256/guest", default-features = false }
+openvm-sha2-circuit = { path = "extensions/sha2/circuit", default-features = false }
+openvm-sha2-transpiler = { path = "extensions/sha2/transpiler", default-features = false }
+openvm-sha2-guest = { path = "extensions/sha2/guest", default-features = false }
 openvm-bigint-circuit = { path = "extensions/bigint/circuit", default-features = false }
 openvm-bigint-transpiler = { path = "extensions/bigint/transpiler", default-features = false }
 openvm-bigint-guest = { path = "extensions/bigint/guest", default-features = false }
@@ -231,6 +231,8 @@ libloading = "0.8"
 tracing-subscriber = { version = "0.3.20", features = ["std", "env-filter"] }
 tokio = "1" # >=1.0.0 to allow downstream flexibility
 abi_stable = "0.11.3"
+ndarray = { version = "0.16.1", default-features = false }
+num_enum = { version = "0.7.4", default-features = false }
 
 # default-features = false for no_std for use in guest programs
 itertools = { version = "0.14.0", default-features = false }

benchmarks/execute/Cargo.toml

@@ -26,8 +26,8 @@ openvm-keccak256-circuit.workspace = true
 openvm-keccak256-transpiler.workspace = true
 openvm-rv32im-circuit.workspace = true
 openvm-rv32im-transpiler.workspace = true
-openvm-sha256-circuit.workspace = true
-openvm-sha256-transpiler.workspace = true
+openvm-sha2-circuit.workspace = true
+openvm-sha2-transpiler.workspace = true
 openvm-continuations = { workspace = true }
 openvm-native-recursion = { workspace = true }
 openvm-sdk = { workspace = true }

benchmarks/execute/benches/execute.rs

@@ -47,8 +47,8 @@ use openvm_sdk::{
     commit::VmCommittedExe,
     config::{AggregationConfig, DEFAULT_NUM_CHILDREN_INTERNAL, DEFAULT_NUM_CHILDREN_LEAF},
 };
-use openvm_sha256_circuit::{Sha256, Sha256Executor, Sha2CpuProverExt};
-use openvm_sha256_transpiler::Sha256TranspilerExtension;
+use openvm_sha2_circuit::{Sha2, Sha2CpuProverExt, Sha2Executor};
+use openvm_sha2_transpiler::Sha2TranspilerExtension;
 use openvm_stark_sdk::{
     config::{baby_bear_poseidon2::BabyBearPoseidon2Engine, FriParameters},
     engine::{StarkEngine, StarkFriEngine},
@@ -144,7 +144,7 @@ pub struct ExecuteConfig {
     #[extension]
     pub keccak: Keccak256,
     #[extension]
-    pub sha256: Sha256,
+    pub sha2: Sha2,
     #[extension]
     pub modular: ModularExtension,
     #[extension]
@@ -165,7 +165,7 @@ impl Default for ExecuteConfig {
             io: Rv32Io,
             bigint: Int256::default(),
             keccak: Keccak256,
-            sha256: Sha256,
+            sha2: Sha2,
             modular: ModularExtension::new(vec![
                 bn_config.modulus.clone(),
                 bn_config.scalar.clone(),
@@ -225,7 +225,7 @@ where
             &config.keccak,
             inventory,
         )?;
-        VmProverExtension::<E, _, _>::extend_prover(&Sha2CpuProverExt, &config.sha256, inventory)?;
+        VmProverExtension::<E, _, _>::extend_prover(&Sha2CpuProverExt, &config.sha2, inventory)?;
         VmProverExtension::<E, _, _>::extend_prover(
             &AlgebraCpuProverExt,
             &config.modular,
@@ -253,7 +253,7 @@ fn create_default_transpiler() -> Transpiler<BabyBear> {
         .with_extension(Rv32MTranspilerExtension)
         .with_extension(Int256TranspilerExtension)
         .with_extension(Keccak256TranspilerExtension)
-        .with_extension(Sha256TranspilerExtension)
+        .with_extension(Sha2TranspilerExtension)
         .with_extension(ModularTranspilerExtension)
         .with_extension(Fp2TranspilerExtension)
         .with_extension(EccTranspilerExtension)

benchmarks/guest/kitchen-sink/openvm.toml

@@ -2,7 +2,7 @@
 [app_vm_config.rv32m]
 [app_vm_config.io]
 [app_vm_config.keccak]
-[app_vm_config.sha256]
+[app_vm_config.sha2]
 [app_vm_config.bigint]
 
 [app_vm_config.modular]

benchmarks/guest/sha256/openvm.toml

@@ -1,4 +1,4 @@
 [app_vm_config.rv32i]
 [app_vm_config.rv32m]
 [app_vm_config.io]
-[app_vm_config.sha256]
+[app_vm_config.sha2]

benchmarks/guest/sha256/src/main.rs

@@ -1,7 +1,7 @@
 use core::hint::black_box;
-use openvm as _;
 
-use openvm_sha2::sha256;
+use openvm as _;
+use openvm_sha2::Sha256;
 
 const INPUT_LENGTH_BYTES: usize = 384 * 1024;
 
@@ -16,5 +16,7 @@ pub fn main() {
     }
 
     // Prevent optimizer from optimizing away the computation
-    black_box(sha256(&black_box(input)));
+    let sha256 = Sha256::new();
+    sha256.update(black_box(&input));
+    black_box(sha256.finalize());
 }