-
Notifications
You must be signed in to change notification settings - Fork 80
feat: update plonky3 to 0.4 #2293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1daf57b to
d1d7dcb
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4528f6e to
7905198
Compare
This comment has been minimized.
This comment has been minimized.
7905198 to
0db0ae4
Compare
This comment has been minimized.
This comment has been minimized.
0db0ae4 to
56b3527
Compare
This comment has been minimized.
This comment has been minimized.
CodSpeed Performance ReportMerging #2293 will improve performances by ×2.2Comparing
|
| Mode | Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|---|
| ⚡ | WallTime | benchmark_execute_metered[quicksort] |
19.5 ms | 9.1 ms | ×2.2 |
Footnotes
-
No successful run was found on
develop-v1.5.0(77adf7e) during the generation of this report, somain(77adf7e) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩ -
36 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
56b3527 to
ca704e2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
810b2c1 to
5cb7f34
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
8806317 to
5226dbe
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
15c5621 to
1ef7d49
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
9060688 to
3cb01ec
Compare
73ba309 to
8888e88
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| p3_baby_bear::BabyBear, | ||
| p3_bn254_fr::Bn254Fr, | ||
| }; | ||
| use p3_bn254::Bn254; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will just remark that their Bn254 naming is confusing because Bn254 is the name of the curve, but it's being used to refer to the scalar field of the curve
jonathanpwang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rand biguint sampling comment can be addressed in a follow-up, but please address the assert_tern and length check comments before merging.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Commit: 455714e |
|
kitchen sink e2e with halo2 on cpu run: https://github.com/openvm-org/openvm/actions/runs/20323776312/job/58384716873 |
Updates to plonky3 v0.4.0. Syncs with openvm-org/stark-backend#195 closes INT-4245 --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
Updates to plonky3 v0.4.0. Syncs with openvm-org/stark-backend#195
closes INT-4245