Skip to content

Conversation

@zlangley
Copy link
Contributor

@zlangley zlangley commented Dec 3, 2025

Updates to plonky3 v0.4.0. Syncs with openvm-org/stark-backend#195

closes INT-4245

@zlangley zlangley force-pushed the update-plonky3 branch 3 times, most recently from 1daf57b to d1d7dcb Compare December 4, 2025 19:59
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 5, 2025

CodSpeed Performance Report

Merging #2293 will improve performances by ×2.2

Comparing update-plonky3 (455714e) with main (77adf7e)1

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 1 improvement
✅ 23 untouched
⏩ 36 skipped2

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
WallTime benchmark_execute_metered[quicksort] 19.5 ms 9.1 ms ×2.2

Footnotes

  1. No successful run was found on develop-v1.5.0 (77adf7e) during the generation of this report, so main (77adf7e) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 36 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@zlangley zlangley force-pushed the update-plonky3 branch 4 times, most recently from 8806317 to 5226dbe Compare December 9, 2025 19:45
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@zlangley zlangley changed the title feat: update plonky3 feat: update plonky3 to 0.4.0 Dec 17, 2025
@zlangley zlangley changed the title feat: update plonky3 to 0.4.0 feat: update plonky3 to 0.4 Dec 17, 2025
p3_baby_bear::BabyBear,
p3_bn254_fr::Bn254Fr,
};
use p3_bn254::Bn254;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will just remark that their Bn254 naming is confusing because Bn254 is the name of the curve, but it's being used to refer to the scalar field of the curve

Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rand biguint sampling comment can be addressed in a follow-up, but please address the assert_tern and length check comments before merging.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@jonathanpwang jonathanpwang added run-benchmark triggers benchmark workflows on the pr run-benchmark-e2e labels Dec 18, 2025
@github-actions
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair 225 322,705 2,059,194 - - -
fibonacci 1,024 1,500,209 2,100,402 2,052 2,381,039 12,952,364
regex 2,352 4,137,502 17,695,216 5,677 5,765,758 46,233,234
ecrecover 805 122,859 2,263,998 2,842 2,936,853 29,780,582
pairing 1,533 1,745,742 25,408,302 2,925 3,905,180 32,402,184
fib_e2e 6,505 12,000,209 14,203,554 14,589 14,103,591 81,241,460
kitchen_sink 2,504 155,210 18,376,578 5,812 10,152,833 118,591,458

Commit: 455714e

Benchmark Workflow

@jonathanpwang
Copy link
Contributor

kitchen sink e2e with halo2 on cpu run: https://github.com/openvm-org/openvm/actions/runs/20323776312/job/58384716873

@jonathanpwang jonathanpwang merged commit fffc4bc into develop-v1.5.0 Dec 18, 2025
108 of 129 checks passed
@jonathanpwang jonathanpwang deleted the update-plonky3 branch December 18, 2025 02:37
branch-rebase-bot bot pushed a commit that referenced this pull request Dec 19, 2025
Updates to plonky3 v0.4.0. Syncs with
openvm-org/stark-backend#195

closes INT-4245

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-benchmark triggers benchmark workflows on the pr run-benchmark-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants