Fix the label for the import date shift input. #2881
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The input that is initally inserted into the page has the id that the label points to. However, that input is hidden and replaced with the visible input for the flatpickr date selector, and so the label does not work. This moves the id of the original and now hidden input onto the visible flatpickr input. This is the same technique used for other date/time inputs in the `htdocs/js/DatePicker/datepicker.js` file, and should have been implemented in this special case as well.
drgrice1
force-pushed
the
fix-import-date-shift-label
branch
from
5be1597 to
b671151
Compare
Member
Author
|
Note that this is redundant (and conflicts) with pull request #2882. So if that is merged first, then this pull request should just be dropped. This is only needed if that pull request is never merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input that is initally inserted into the page has the id that the label points to. However, that input is hidden and replaced with the visible input for the flatpickr date selector, and so the label does not work. This moves the id of the original and now hidden input onto the visible flatpickr input.
This is the same technique used for other date/time inputs in the
htdocs/js/DatePicker/datepicker.jsfile, and should have been implemented in this special case as well.