Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it seems there is no enough review time #1533 and the PR fixing the underlying issue which misleaded to the referenced revert commits has been merged:
maybe just reverting to an known working state have better luck.
This would allow to use firmware-selector for the gl-mt2500 MaxLinear PHY case even Owut or Luci ASU app with the workaround of
echo "glinet_gl-mt2500" > /tmp/sysinfo/board_namefor the MaxLinear users.The key here, IMHO, is that we have to make clearer the difference between "profile" and "DT compatible string" and for that I am thinking about some variable/messages renames could help also, but in order to prioritize, the code implied in the proposed reverts is the key and I think it goes in opposite direction.
#1525 (comment)
Right now we got this when generating the app.profiles[version][target]
Before commit "sanitize profile" 1579236
This do not implies nothing about which of PR fixing the gl-mt2500 issue in the openwrt repo will be finally merged: