Skip to content

firewall3: fix process termination in child processes #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stacycorcoran wants to merge 1 commit into
base: master
Choose a base branch
from
Open

firewall3: fix process termination in child processes #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions utils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,10 @@ __fw3_command_pipe(bool silent, const char *command, ...)

execv(command, args);

/* Only reach on execv failure - must exit to prevent child continuing */
warn("Unable to execute %s: %s", command, strerror(errno));
_exit(1);

default:
signal(SIGPIPE, SIG_IGN);
pipe_pid = pid;
Expand Down Expand Up @@ -771,7 +775,7 @@ fw3_hotplug(bool add, void *zone, void *device)
switch (fork())
{
case -1:
warn("Unable to fork(): %s\n", strerror(errno));
warn("Unable to fork(): %s", strerror(errno));
return false;

case 0:
Expand All @@ -794,8 +798,8 @@ fw3_hotplug(bool add, void *zone, void *device)

execl(FW3_HOTPLUG, FW3_HOTPLUG, "firewall", NULL);

/* unreached */
return false;
/* Only reach on execl() failure - must exit to prevent child continuing */
_exit(1);
}

int
Expand Down