config: Drop unaccounted icmp6 packets #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop ICMPv6 packets that are not explicitly allowed, like falling outside conntrack due to missing embedded state header like in referenced issue Add older patch and omit singular echo reply as it is traditionally seen only in conntrack state only initiated by echo request Fixes: openwrt/openwrt#17800 Supersedes: openwrt/openwrt#17805 Supersedes: openwrt#38 Signed-off-by:
Author
|
I'd suggest closing #38 if it's not longer relevant: there were no 3rd-party comments there and this will ease maintainer's workload. |
Author
|
Kind of does not change much... I linked it to shoot all at once. |
Contributor
|
Please remove the commented out lines and prefix the commit subject with |
dave14305
reviewed
Mar 17, 2025
brada4
changed the title
drop comment fix typo Signed-off-by: Andris PE <neandris@gmail.com>
Author
|
@jow- @dave14305 hope all issues fixed? |
1 task
brada4
added a commit
to brada4/openwrt
that referenced
this pull request
Dec 11, 2025
Do not accept unsolicited ICMP echo reply. It is implied by conntrack state from request already. cf openwrt/firewall4#44 Also exemplified by ipv4 ping rule Limit peer-to-peer ipsec to ipv6 only as stated in original "ipv6 cpe requirements" cf openwrt/firewall4#65 Signed-off-by:
brada4
added a commit
to brada4/openwrt
that referenced
this pull request
Dec 11, 2025
Do not accept unsolicited ICMP echo reply. It is implied by conntrack state from request already. cf openwrt/firewall4#44 Also exemplified by ipv4 ping rule Limit peer-to-peer ipsec to ipv6 only as stated in original "ipv6 cpe requirements" cf openwrt/firewall4#65 Signed-off-by: Andris PE <neandris@gmail.com>
brada4
added a commit
to brada4/openwrt
that referenced
this pull request
Dec 11, 2025
Do not accept unsolicited ICMP echo reply. It is implied by conntrack state from request already. cf openwrt/firewall4#44 Also exemplified by ipv4 ping rule Limit peer-to-peer ipsec to ipv6 only as stated in original "ipv6 cpe requirements" cf openwrt/firewall4#65 Signed-off-by: Andris PE <neandris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop ICMPv6 packets that are not explicitly allowed, like falling outside conntrack due to missing embedded state header like in referenced issue
Add older patch and omit singular echo reply as it is traditionally seen only in conntrack state only initiated by echo request.
Fixes: openwrt/openwrt#17800
Supersedes: openwrt/openwrt#17805
Supersedes: #38
Signed-off-by: Andris PE neandris@gmail.com