Skip to content

Conversation

@XCas13
Copy link

@XCas13 XCas13 commented Aug 11, 2025

Added missing code for handling ipset counters mentioned in this issue

@brada4
Copy link

brada4 commented Aug 12, 2025

Please add a commit message
(not good to pr from master as your fork is now unbranchable)

: git switch pr-branch
git commit --amend # add brief description like in PR letter and Sob, and probably Fixes: to auto-close the issue on merge)
git push --force

Technical content is perfect.

@XCas13
Copy link
Author

XCas13 commented Aug 12, 2025

@brada4 Thanks for heads up. Done

@brada4
Copy link

brada4 commented Aug 12, 2025

Same recipe - add Signed-off-by: NAME <email@domain.com>
romise you will get couple of misguided user mails which you can politely bring to forums or bug tracker or ignore.

Copy link

@brada4 brada4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch adds missing counter to nftables set definition thus adding expected feature toour firewall.

Added missing code to support counters for ipsets

Fixes: openwrt#69
Signed-off-by: XCas13 <xcas13@gmail.com>
@XCas13
Copy link
Author

XCas13 commented Aug 12, 2025

Same recipe - add Signed-off-by: NAME <email@domain.com>
Ok. Done. I thought approvers signed pull requests.

For some reason there were spaces instead of tabs, causing failed tests.

Fixes: openwrt#69
Signed-off-by: XCas13 <xcas13@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants