Skip to content

Conversation

@rdevshp
Copy link

@rdevshp rdevshp commented Nov 12, 2025

This pull request fixes openwrt/openwrt#20723

… execution of hotplug scripts

Signed-off-by: rdevshp <rdevshp@gmail.com>
@brada4
Copy link

brada4 commented Nov 12, 2025

Something similar by @ptpt52 (pre-dating my impromptu re-invention) ? https://github.com/x-wrt/x-wrt/blob/master/package/network/config/firewall4/patches/200-fw4-hotplug-fork.patch

Copy link

@brada4 brada4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to limit forking of new copies of reload attempts , rapid flipping of link externally would unnecesarily accumulate waiting background tasks.

@rdevshp
Copy link
Author

rdevshp commented Nov 12, 2025

What do you think would be the ideal approach here to avoid excessive reload attempts & unnecessarily accumulate background tasks?
I am planning to create a new service that actually executes fw4 -q reload, and the 20-firewall script would merely send a fw4 reload notification to the new service without actually doing the reload itself. Do you think this is a good idea?

@brada4
Copy link

brada4 commented Nov 13, 2025

It is not about clicks in the interface that go in sync with 🤣 background 🤣 activity, it is about rapidly (I tried 10hz) flipping connected ethernet with zone like wan and building up said activities.
(but totally agree massive cpu time hogs should be out of hotplug)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Very slow ifup /etc/hotplug.d/iface script performance

2 participants