babeld: add del_filters function #911
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PolynomialDivision
force-pushed
the
babeld-ubus-del-filters
branch
from
8f09713 to
f47470b
Compare
This commit adds the ubus function to dynamically delete filters on
runtime:
ubus call babeld del_filters '{"ifname":"eth0"}'
Signed-off-by: Nick Hainke <vincent@systemli.org>
PolynomialDivision
force-pushed
the
babeld-ubus-del-filters
branch
from
f47470b to
48d1ab0
Compare
PolynomialDivision
changed the title
BKPepe
reviewed
Mar 3, 2023
| From 7dc87f39dc5d1db7654f6ad89eca77766812affd Mon Sep 17 00:00:00 2001 | ||
| From: Nick Hainke <vincent@systemli.org> | ||
| Date: Tue, 18 Oct 2022 21:34:03 +0200 | ||
| Subject: [PATCH] Add functions to delete filters from an interface |
Member
|
May I know which is your use case or if you are using this anyhow these days? Code was reviewed that's ok, but babeld's developer said that adding these two function to upstream does not make any sense as it is not used, but you are using this here. So, I think this can go through, though, and it will give time to babeld's developer to come up with something better, as he said. |
Member
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ubus function to dynamically delete filters on runtime:
ubus call babeld del_filters '{"ifname":"eth0"}'
Maintainer: me, @kerneis
Compile tested: belkin rt3200
Run tested: belkin rt3200