Linux 6.19 compat #18053
Open
Linux 6.19 compat #18053
+43
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Ahh, new when Seems like it keeps running ok, but obviously gonna need to do some updates. i'll have a look when I can this week. |
robn
added
the
Status: Revision Needed
Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <robn@despairlabs.com>
Since Linux 4.12 (torvalds/linux@19809c2da28ae) __GFP_HIGHMEM has been automatically added to calls to __vmalloc() internally, so we don't need it anymore. This is good, because since 6.19 the kernel warns if you use __GFP_HIGHMEM. Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <robn@despairlabs.com>
It hasn't been necessary since Linux 3.13 (torvalds/linux@a57a49887eb33), and since 6.19 the kernel warns if you use it. Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <robn@despairlabs.com>
robn
force-pushed
the
linux-6.19-compat
branch
from
1651202 to
3125c8b
Compare
github-actions
bot
removed
the
Status: Revision Needed
Member
Author
|
Last push hopefully sorts out the vmalloc flag changes. |
behlendorf
approved these changes
Dec 18, 2025
Contributor
behlendorf
left a comment
behlendorf
left a comment
There was a problem hiding this comment.
Thanks again Rob for working through these changes. The churn is never ending! It's nice that what was needed was pretty minimal this time around. Plus those new warnings prompted us to drop those old flags.
behlendorf
added
Status: Accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
6.19-rc1 arrives with the gift of minimal changes 🎄.
Description
Two changes (over three commits):
i_stateinstruct inodeis no longer directly accessible, and a macroinode_state_read_once()is provided to get it. I've added a test for that macro and a definition for older kernels. We only use it in one place, so all together a very small change.__vmalloc()is now warning on "invalid" GFP flags, which pointed out places where we're no longer correctly using__GFP_HIGHMEMand__GFP_COMP. Adjusted, see commit messages.How Has This Been Tested?
Compile checked on: 4.19.325 5.10.240 6.1.159 6.6.101 6.12.41 6.18.0 and 6.19-rc1.
ZTS passed: 6.19-rc1.
Types of changes
Checklist:
Signed-off-by.