Skip to content

Conversation

@benoit74
Copy link
Contributor

Significant rework following latest discussions around the concepts of jail, staging and collections:

  • drop the concept of warehouse_path
  • drop the concept of library
  • add the concept of collection
  • add the fact the collection and titles have a mapping table, where we decide under which path a given title is published

@benoit74 benoit74 self-assigned this Dec 22, 2025
@benoit74 benoit74 changed the base branch from main to cms-upgrade December 22, 2025 14:39
@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 84.43396% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.74%. Comparing base (4c0dcdf) to head (3fc946c).
⚠️ Report is 3 commits behind head on cms-upgrade.

Files with missing lines Patch % Lines
backend/src/cms_backend/mill/processors/title.py 72.54% 14 Missing ⚠️
backend/src/cms_backend/mill/processors/book.py 77.77% 10 Missing ⚠️
backend/src/cms_backend/db/models.py 90.47% 2 Missing and 2 partials ⚠️
backend/src/cms_backend/api/main.py 60.00% 2 Missing ⚠️
backend/src/cms_backend/db/title.py 33.33% 1 Missing and 1 partial ⚠️
.../cms_backend/mill/process_zimfarm_notifications.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           cms-upgrade     #132      +/-   ##
===============================================
- Coverage        81.21%   78.74%   -2.48%     
===============================================
  Files               36       34       -2     
  Lines             1203     1143      -60     
  Branches           104      100       -4     
===============================================
- Hits               977      900      -77     
- Misses             202      223      +21     
+ Partials            24       20       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74 benoit74 marked this pull request as ready for review December 22, 2025 15:29
@benoit74 benoit74 merged commit 8686736 into cms-upgrade Dec 22, 2025
5 of 6 checks passed
@benoit74 benoit74 deleted the big_rework branch December 22, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants