detect template type from input, but respect explicit specification #1844

grokspawn · 2025-11-25T03:41:07Z

Description of the change:
Replaces #1814

Various type changes and refactoring necessary to make opm alpha render-template capable of detecting the template type from sniffing its schema, as well as name standardization across all template types and a new factory-based creation pattern.

This absolutely sacrifices stability of the API in favor of stability of the datatypes and callflows for future growth.

Motivation for the change:
Since we created a formal schema for the basic catalog template, it made much more sense for Template to be an interface for a creation/call pattern which was increasingly entrenched in users' tooling... so it was easy to put off. But since it was also largely a "move existing stuff around" activity (read: super simple operations with complex propagation and high potential for side effects), it seemed a great opportunity to see what Claude would do with it.

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation
Sufficient unit test coverage
Sufficient end-to-end test coverage
Docs updated or added to /docs
Commit messages sensible and descriptive

codecov · 2025-11-25T03:45:35Z

Codecov Report

❌ Patch coverage is 54.19847% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.51%. Comparing base (b7c3f27) to head (a4b0045).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
alpha/template/basic/basic.go	0.00%	27 Missing ⚠️
alpha/template/registry.go	70.96%	18 Missing ⚠️
alpha/template/semver/semver.go	48.00%	13 Missing ⚠️
alpha/template/schema.go	88.23%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #1844    +/-   ##
========================================
  Coverage   57.50%   57.51%            
========================================
  Files         136      137     +1     
  Lines       12934    13035   +101     
========================================
+ Hits         7438     7497    +59     
- Misses       4341     4382    +41     
- Partials     1155     1156     +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

This PR refactors the template rendering system to support automatic template type detection based on schema fields, while still allowing explicit type specification. The changes consolidate the previously separate basic and semver subcommands into a unified render-template command that can auto-detect the template type from the input file's schema field.

Key Changes:

Introduced a common Template interface and factory pattern for all template types
Implemented schema-based auto-detection using a registry system
Unified the command structure from separate subcommands to a single command with optional type specification

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`cmd/opm/alpha/template/cmd.go`	Replaced separate subcommands with unified `render-template` command that accepts optional TYPE and FILE arguments
`cmd/opm/alpha/template/render.go`	New file implementing unified rendering logic with auto-detection and explicit type specification support
`cmd/opm/alpha/template/basic.go`	Removed - functionality moved to unified render.go
`cmd/opm/alpha/template/semver.go`	Removed - functionality moved to unified render.go
`alpha/template/template.go`	New file defining Template interface, TemplateFactory interface, and Registry for schema-based template creation
`alpha/template/schema.go`	New file implementing schema detection from YAML/JSON input
`alpha/template/basic/basic.go`	Refactored to implement new Template interface with factory pattern; renamed data struct to BasicTemplateData
`alpha/template/semver/semver.go`	Refactored to implement new Template interface with factory pattern; moved type definitions from types.go and renamed to SemverTemplateData
`alpha/template/semver/types.go`	Removed - content migrated into semver.go
`alpha/template/semver/semver_test.go`	Updated test assertions to use SemverTemplateData and changed to ElementsMatch for order-independent comparison

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.