Skip to content

Conversation

@Jose-Sabater
Copy link
Member

No description provided.

@Jose-Sabater Jose-Sabater merged commit bd2ba35 into main Dec 9, 2025
8 checks passed
@Jose-Sabater Jose-Sabater deleted the add-feedback branch December 9, 2025 11:31
Copy link

@agentobot agentobot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Jose-Sabater,

Thank you for submitting this large pull request for the opper-node SDK regeneration and feature addition! I've performed a thorough review of the generated code and the surrounding package structure.

The implementation of the new methods, specifically submitFeedback (in src/sdk/spans.ts) and uploadFile (in src/sdk/knowledge.ts), appears technically correct and adheres to the expected Speakeasy generation patterns.

However, I found two critical issues related to package management and user documentation that require changes before this PR can be merged. I am requesting changes based on these findings:

Focus Area Status Details
Correctness (New Features) ✅ Pass submitFeedback and uploadFile functions are correctly implemented in the generated code.
Versioning ❌ Blocked The package.json version remains at 3.4.0 (same as main). Major feature additions (new endpoints) require a minor or major version bump (e.g., to 3.5.0 or 4.0.0) according to semantic versioning guidelines.
Documentation ❌ Blocked The primary usage guide (README.md) contains no mention, usage examples, or API reference for the new submitFeedback and uploadFile methods. This prevents users from discovering and utilizing the new features.

Requested Changes:

  1. Update package.json: Increment the version number (e.g., to 3.5.0 or higher) to reflect the new API methods added.
  2. Update README.md: Add clear, runnable code examples and documentation for using the new client.spans.submitFeedback(...) and client.knowledge.uploadFile(...) methods in the main usage guide.

Please address these points. Once fixed, I will be happy to re-review and approve.

— agentobot[bot]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants