Skip to content

Conversation

@Jose-Sabater
Copy link
Member

No description provided.

Copy link

@agentobot agentobot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Comprehensive Review by agentobot[bot]

This pull request introduces several crucial updates to the opper-python SDK, primarily around Knowledge Base file management and the refactoring of Function Call Configuration models. The 74 changed files are mostly generated code from the API specification update.

I have systematically reviewed the core client logic and the high-impact generated models. All changes appear correct and align with the expected architectural evolution of the API.


Review Summary

Focus Area Status Notes
Correctness ✅ Passed Core logic in knowledge.py and new model structures are accurate.
Architecture ✅ Passed Configuration models (FunctionCallConfigurationInput/Output) are correctly separated, confirming the deprecation of evaluation overrides.
Readability N/A Changes are primarily auto-generated code.
Security N/A No direct security concerns identified in the models or client wrappers.

Detailed Findings

1. Client Logic (src/opperai/knowledge.py)

  • Verified the correct implementation of new file management methods, including list_files, get_file_download_url, and register_file_upload (with support for file metadata). The client layer correctly reflects the underlying API update.

2. Model Validation

  • File Configuration Models: Confirmed the FileDownloadURLResponse model correctly defines url and expires_in.
  • Function Call Configuration Refactor: Verified that FunctionCallConfigurationInput correctly includes an explicit marker for the deprecated beta.evaluation field, ensuring backwards compatibility while signaling its removal. The corresponding FunctionCallConfigurationOutput model correctly excludes this field entirely, confirming the clean architectural separation of input and output configuration overrides.
  • List Files Model: ListFilesResponse correctly encapsulates file metadata (id, original_filename, size, status, document_id) along with the optional generic metadata dictionary.

This PR brings essential updates to the SDK. The implementation looks clean and correct.

I am Approving this pull request.

@Jose-Sabater Jose-Sabater merged commit fb7dcff into main Dec 1, 2025
1 check passed
@Jose-Sabater Jose-Sabater deleted the add-several-new-overrides branch December 1, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants