Skip to content

Fix/podspec enable name handling #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PhennyOpsta wants to merge 2 commits into from
Closed

Fix/podspec enable name handling #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b702a00
correct serviceAccountName logic in podspec
nakarin-s Feb 6, 2026
4ea274b
update serviceaccount flow
PhennyOpsta Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/common/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ type: library
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.8.0
version: 0.9.0
2 changes: 1 addition & 1 deletion charts/common/templates/_podSpec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,4 +80,4 @@ affinity:
tolerations:
{{- toYaml . | nindent 2 }}
{{- end }}
{{- end }}
{{- end }}
6 changes: 2 additions & 4 deletions charts/common/templates/_serviceaccount.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
{{- define "common.serviceaccount.tpl" -}}
{{- if .Values.serviceAccount.create -}}
{{- if .Values.serviceAccount }}
---
apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ .Values.serviceAccount.name | default (include "onechart.fullname" .) }}
name: {{ .Values.serviceAccount }}
Copy link

@gemini-code-assist gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

A YAML injection vulnerability exists here as the user-provided value .Values.serviceAccount is rendered directly without quoting, potentially allowing for malicious metadata injection. It is critical to use the quote function to prevent this. Furthermore, the current ServiceAccount creation logic in this block introduces a regression by removing the ability to use existing ServiceAccounts and omitting standard labels, which are essential for resource management.

  name: {{ .Values.serviceAccount | quote }}

namespace: {{ .Release.Namespace }}
labels:
{{- include "onechart.labels" . | nindent 4 }}
{{- end }}
{{- end -}}
6 changes: 3 additions & 3 deletions charts/cron-job/Chart.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
dependencies:
- name: common
repository: file://../common
version: 0.8.0
digest: sha256:ffc064a8d35b9d9d6e48490b41d0caef00096b0c8f9d1b773dfd9380efdff440
generated: "2026-02-06T16:56:07.364305478+07:00"
version: 0.9.0
digest: sha256:c691781bff5490003ec6b84de1a1f71ab89d193325e5f5fe1c83b8c1398e2273
generated: "2026-02-09T14:46:51.755970924+07:00"
4 changes: 2 additions & 2 deletions charts/cron-job/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.78.0
version: 0.77.0
Copy link

@gemini-code-assist gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The chart version has been decremented from 0.78.0 to 0.77.0. This violates Semantic Versioning principles and can break dependency management and deployment pipelines. The version should be incremented to reflect the new changes. Given this is a feature change, a minor version bump is appropriate.

version: 0.79.0


dependencies:
- name: common
version: 0.8.0
version: 0.9.0
repository: file://../common
Binary file removed charts/cron-job/charts/common-0.8.0.tgz
View file
Open in desktop
Binary file not shown.
Binary file added charts/cron-job/charts/common-0.9.0.tgz
View file
Open in desktop
Binary file not shown.
6 changes: 3 additions & 3 deletions charts/onechart/Chart.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
dependencies:
- name: common
repository: file://../common
version: 0.8.0
digest: sha256:ffc064a8d35b9d9d6e48490b41d0caef00096b0c8f9d1b773dfd9380efdff440
generated: "2026-02-06T14:23:44.297299351+07:00"
version: 0.9.0
digest: sha256:c691781bff5490003ec6b84de1a1f71ab89d193325e5f5fe1c83b8c1398e2273
generated: "2026-02-09T14:47:43.892718793+07:00"
4 changes: 2 additions & 2 deletions charts/onechart/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.78.0
version: 0.77.0
Copy link

@gemini-code-assist gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The chart version has been decremented from 0.78.0 to 0.77.0. This violates Semantic Versioning principles and can break dependency management and deployment pipelines. The version should be incremented to reflect the new changes. Given this is a feature change, a minor version bump is appropriate.

version: 0.79.0


dependencies:
- name: common
version: 0.8.0
version: 0.9.0
repository: file://../common
Binary file removed charts/onechart/charts/common-0.8.0.tgz
View file
Open in desktop
Binary file not shown.
Binary file added charts/onechart/charts/common-0.9.0.tgz
View file
Open in desktop
Binary file not shown.
8 changes: 8 additions & 0 deletions charts/onechart/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1225,6 +1225,14 @@
}
]
}
},
"serviceAccount": {
"$id": "#/properties/serviceAccount",
"type": "string",
"title": "The name of service account",
"description": "Name of the Kubernetes ServiceAccount to associate with this workload. If not specified, the chart will automatically create one.",
Copy link

@gemini-code-assist gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The description for serviceAccount is misleading. It states "If not specified, the chart will automatically create one." However, the template logic in _serviceaccount.yaml ({{- if .Values.serviceAccount }}) will only create a service account if a name is provided. If it's not specified (i.e., an empty string), no service account is created. The description should be updated to accurately reflect the actual behavior of the chart.

Suggested change
"description": "Name of the Kubernetes ServiceAccount to associate with this workload. If not specified, the chart will automatically create one.",
"description": "Name of the Kubernetes ServiceAccount to associate with this workload. If a name is provided, a new ServiceAccount will be created with that name. If not specified, no ServiceAccount will be created or used.",

"default": "",
"examples": []
}
},
"additionalProperties": true
Expand Down
4 changes: 0 additions & 4 deletions charts/onechart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ image:
# vars:
# MY_VAR: "value"

serviceAccount:
create: false
# name: my-service-account

replicas: 1

nameOverride: ""
Expand Down
6 changes: 3 additions & 3 deletions charts/static-site/Chart.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
dependencies:
- name: common
repository: file://../common
version: 0.8.0
digest: sha256:ffc064a8d35b9d9d6e48490b41d0caef00096b0c8f9d1b773dfd9380efdff440
generated: "2026-02-06T16:56:24.024306149+07:00"
version: 0.9.0
digest: sha256:c691781bff5490003ec6b84de1a1f71ab89d193325e5f5fe1c83b8c1398e2273
generated: "2026-02-09T15:31:53.899987212+07:00"
4 changes: 2 additions & 2 deletions charts/static-site/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.78.0
version: 0.77.0
Copy link

@gemini-code-assist gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The chart version has been decremented from 0.78.0 to 0.77.0. This violates Semantic Versioning principles and can break dependency management and deployment pipelines. The version should be incremented to reflect the new changes. Given this is a feature change, a minor version bump is appropriate.

version: 0.79.0


dependencies:
- name: common
version: 0.8.0
version: 0.9.0
repository: file://../common
Binary file removed charts/static-site/charts/common-0.8.0.tgz
View file
Open in desktop
Binary file not shown.
Binary file added charts/static-site/charts/common-0.9.0.tgz
View file
Open in desktop
Binary file not shown.
Binary file removed common-0.8.0.tgz
View file
Open in desktop
Binary file not shown.
Binary file added common-0.9.0.tgz
View file
Open in desktop
Binary file not shown.