Skip to content

fix: await queue lock operations and fix variable name bug #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Its-donkey wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: await queue lock operations and fix variable name bug #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/commands/songRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ const handleSongRequest = async (
tags["user-id"]!
);

if (!createRequest) {
if (!createdRequest) {
twitch.say(channel, `Error creating request DinkDank @opti_21`);
return;
}
Expand Down
20 changes: 10 additions & 10 deletions src/redis/handlers/Queue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ async function addToQueue(
return;
}

lockQueue();
await lockQueue();

await connect();

Expand All @@ -186,7 +186,7 @@ async function addToQueue(

await repository.save(queue);

unLockQueue();
await unLockQueue();

pusher.trigger(process.env.NEXT_PUBLIC_PUSHER_CHANNEL!, "queue-add", queue);

Expand All @@ -201,7 +201,7 @@ async function removeFromOrder(
requestID: string | undefined
): Promise<boolean> {
try {
lockQueue();
await lockQueue();

await connect();

Expand All @@ -219,7 +219,7 @@ async function removeFromOrder(

await repository.save(queue);

unLockQueue();
await unLockQueue();

return true;
} catch (e) {
Expand All @@ -233,7 +233,7 @@ async function updateOrder(updatedOrderData: any): Promise<boolean> {
return request.id;
});

lockQueue();
await lockQueue();

await connect();

Expand All @@ -245,7 +245,7 @@ async function updateOrder(updatedOrderData: any): Promise<boolean> {

await repository.save(queue);

unLockQueue();
await unLockQueue();

return true;
} catch (e) {
Expand All @@ -255,7 +255,7 @@ async function updateOrder(updatedOrderData: any): Promise<boolean> {

async function updateOrderIdStrings(updatedOrder: string[]): Promise<boolean> {
try {
lockQueue();
await lockQueue();

await connect();

Expand All @@ -267,7 +267,7 @@ async function updateOrderIdStrings(updatedOrder: string[]): Promise<boolean> {

await repository.save(queue);

unLockQueue();
await unLockQueue();

return true;
} catch (e) {
Expand All @@ -278,7 +278,7 @@ async function updateOrderIdStrings(updatedOrder: string[]): Promise<boolean> {

async function updateNowPlaying(requestID: string): Promise<boolean> {
try {
lockQueue();
await lockQueue();

await connect();

Expand All @@ -290,7 +290,7 @@ async function updateNowPlaying(requestID: string): Promise<boolean> {

await repository.save(queue);

unLockQueue();
await unLockQueue();

return true;
} catch (e) {
Expand Down