Skip to content

added React router, renamed approutes, fixed package-lock errors#29

Open
parthsarthiprasad wants to merge 1 commit intoorcasound:mainfrom
parthsarthiprasad:reactRouter
Open

added React router, renamed approutes, fixed package-lock errors#29
parthsarthiprasad wants to merge 1 commit intoorcasound:mainfrom
parthsarthiprasad:reactRouter

Conversation

@parthsarthiprasad
Copy link
Contributor

@parthsarthiprasad parthsarthiprasad commented Mar 20, 2021

Following #9 ,
Suggestion

adding routes for different components
changes done

Adding Approutes using react-router;

#9 can be closed now as the folder currently has been refactored, @ivanoats for extension of features of orcamap v1 in react-based, we would need to extend few components as per Q1-Q2 roadmap.
Further routes can be added using the current react-router.

@netlify
Copy link

netlify bot commented Mar 20, 2021

Deploy request for orcamap accepted.

Accepted with commit bf6f5d8

https://app.netlify.com/sites/orcamap/deploys/6055956972d88200077c89d6

@ivanoats
Copy link
Member

This adds React Router - but why? What significant code does it add that needs routes? Also, does it conflict with any other previous outstanding PRs? #26 ?

@parthsarthiprasad
Copy link
Contributor Author

parthsarthiprasad commented Mar 20, 2021

@ivanoats I might have to rebase and resolve merge conflict if #26 is merged prior to this. I was thinking of adding further routes following suggestion from previous PR of #9 only.
If we only have a single map component then we won't require any usage of routes but
was in consideration of further addition of pages in future ?
What are your suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants