added React router, renamed approutes, fixed package-lock errors#29
Open
parthsarthiprasad wants to merge 1 commit intoorcasound:mainfrom
Open
added React router, renamed approutes, fixed package-lock errors#29parthsarthiprasad wants to merge 1 commit intoorcasound:mainfrom
parthsarthiprasad wants to merge 1 commit intoorcasound:mainfrom
Conversation
|
Deploy request for orcamap accepted. Accepted with commit bf6f5d8 https://app.netlify.com/sites/orcamap/deploys/6055956972d88200077c89d6 |
Member
|
This adds React Router - but why? What significant code does it add that needs routes? Also, does it conflict with any other previous outstanding PRs? #26 ? |
Contributor
Author
|
@ivanoats I might have to rebase and resolve merge conflict if #26 is merged prior to this. I was thinking of adding further routes following suggestion from previous PR of #9 only. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #9 ,
Suggestion
adding routes for different components
changes done
Adding Approutes using react-router;
#9 can be closed now as the folder currently has been refactored, @ivanoats for extension of features of orcamap v1 in react-based, we would need to extend few components as per Q1-Q2 roadmap.
Further routes can be added using the current react-router.