Skip to content

Conversation

@piersi021
Copy link

This is my Entrepreneurship EDA Streamlit Dashboard. Any and all feedback is helpful!

Thanks,
Pierce

@piersi021 piersi021 marked this pull request as draft September 23, 2022 00:41
@@ -0,0 +1,45 @@
# Note: In order to get your Streamlit Dashboard running, you'll need to enter the following command: streamlit run main.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: you should include a requirements file and your dataset -- any thing you push to github should be runable from cloning!



# Imports
import time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you use the time module? make sure all of your imports are used, otherwise not necessary

@@ -0,0 +1,45 @@
# Note: In order to get your Streamlit Dashboard running, you'll need to enter the following command: streamlit run main.py
# This will be run in the shell everytime you start the site again. If stuck, feel free to fork the tutorial Rep.lit dashboard and make changes that way.
# Dataset link: https://www.kaggle.com/namanmanchanda/entrepreneurial-competency-in-university-students
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best to upload the actual csv or rewrite your code to pull this CSV directly :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by upload the actual csv i mean include it in your commit!

# Title & Intro
st.title("Example EDA: Predicting Entrepreneurial Potential in Students")
st.header("For this EDA, I decided to explore the relationship between different qualities that make someone a good enrepreneur.")
# Head and Tail
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would add spacing if you are going to section out your code with comments like this! so would add an empty line between 15 and 16, etc.

st.write(data.count())
st.write("This function counts the number of values for all variables in the dataset.")
# Scatter Plot
fig_One = px.scatter(data, x = "SelfConfidence", y = "Perseverance")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

poor naming convention. it should be fig_one. see https://en.wikipedia.org/wiki/Snake_case

Copy link
Contributor

@mbcutts mbcutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job, just a few notes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants