Skip to content

Fix transformation issue of 'require' #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flyfishzy merged 2 commits into from
Feb 17, 2022
Merged

Fix transformation issue of 'require' #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e2f192
Fix transformation issue of 'require'
MartinKolbAtWork Feb 16, 2022
ea99156
Remove added devDependencies for test execution
MartinKolbAtWork Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/vite-plugin-commonjs/__tests__/transform.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,18 @@ test('transform require', () => {
expect(result.code).toMatch(/import \* as .+ from \'@\/page\/login';/);
});

test('require function on object', () => {
let code = `myObj.require("react");`
let result = transformRequire(code, 'main.ts');
expect(result.code).toMatch(`myObj.require("react");`);
});

test('require as part of function name', () => {
let code = `myrequire("react");`
let result = transformRequire(code, 'main.ts');
expect(result.code).toMatch(`myrequire("react");`);
});

test('require in comments', () => {
//singleline comments
let code = ` const a=0; // the hook will be setup by require("react").`
Expand Down
2 changes: 1 addition & 1 deletion packages/vite-plugin-commonjs/src/lib.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const commonJSRegex: RegExp = /\b(module\.exports|exports\.\w+|exports\s*=\s*|exports\s*\[.*\]\s*=\s*)/;
const requireRegex: RegExp = /_{0,2}require\s*\(\s*(["'].*?["'])\s*\)/g;
const requireRegex: RegExp = /(?<!\.)\b_{0,2}require\s*\(\s*(["'].*?["'])\s*\)/g;
const IMPORT_STRING_PREFIX: String = "__require_for_vite";
const multilineCommentsRegex = /\/\*(.|[\r\n])*?\*\//gm
const singleCommentsRegex = /([^\:])\/\/.*/g
Expand Down