feat: source-map using MagicString #46
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Jun 23, 2023
| removeComments(ms, singleCommentsRegex); | ||
|
|
||
| const requireMatches = code.matchAll(requireRegex); | ||
| const requireMatches = ms.toString().matchAll(requireRegex); |
Author
There was a problem hiding this comment.
These steps might not work correctly, because the modified string is being returned here, but replacements happen in the original string.
This should probably be improved, but I feel this code needs to be modified anyway (with a proper JS parser instead of regex).
ghost
mentioned this pull request
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes misalignment of
debuggerstatements etc. when using this plugin, which forced us back to Webpack.Barely tested due to:
We'll probably migrate to another package which has a proper JS parser (instead of hacky regex), so I'm not sure how much time I'll invest into improving this PR.