test: add comprehensive tests for InsightsService month period logic#1
Open
test: add comprehensive tests for InsightsService month period logic#1
Conversation
Added 18 test cases covering critical month period calculation functions: - GetMonthPeriod: Tests standard months, custom start days (1-28), leap years, non-leap years, year boundaries, and all 12 months for consistency - GetCurrentMonthPeriod: Tests date logic for determining current period based on dates before, on, and after the start_of_month configuration, including year boundary scenarios - GetPeriodForDate: Tests period assignment for specific dates including edge cases on period boundaries, before/after start day, year boundaries, and February edge cases in leap years These tests ensure the custom month period logic (supporting start_of_month config from 1-28) works correctly across all scenarios, which is critical since this logic affects all financial calculations in the application. All 18 tests pass successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 18 test cases covering critical month period calculation functions:
GetMonthPeriod: Tests standard months, custom start days (1-28), leap years, non-leap years, year boundaries, and all 12 months for consistency
GetCurrentMonthPeriod: Tests date logic for determining current period based on dates before, on, and after the start_of_month configuration, including year boundary scenarios
GetPeriodForDate: Tests period assignment for specific dates including edge cases on period boundaries, before/after start day, year boundaries, and February edge cases in leap years
These tests ensure the custom month period logic (supporting start_of_month config from 1-28) works correctly across all scenarios, which is critical since this logic affects all financial calculations in the application.
All 18 tests pass successfully.