refactor: use external test packages #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add export pattern to access unexported functions from external test packages Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Change package csvpp to package csvpp_test - Add proper imports and package prefixes Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Change package csvpputil to package csvpputil_test - Add proper imports and package prefixes Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Enable recvtype analyzer (remove from disable list) - Add nostyle:recvtype directive to FieldKind.String() - Remove unnecessary exclude-test settings Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
*_test)Test plan
GOEXPERIMENT=jsonv2 go test ./...passesGOEXPERIMENT=jsonv2 go tool gostyle run ./...passes🤖 Generated with Claude Code