rift_O4b_JL - hyperbolic merge request#93
Open
chadhenshaw wants to merge 52 commits intooshaughn:rift_O4b_JLfrom
Open
rift_O4b_JL - hyperbolic merge request#93chadhenshaw wants to merge 52 commits intooshaughn:rift_O4b_JLfrom
chadhenshaw wants to merge 52 commits intooshaughn:rift_O4b_JLfrom
Conversation
chadhenshaw
commented
May 22, 2024
Contributor
Author
chadhenshaw
left a comment
chadhenshaw
left a comment
There was a problem hiding this comment.
Largely minor changes to syntax; the single_inject code is how I've been making injections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jlange2010 @oshaughn This is the most up-to-date hyperbolic code, following completion of a full injection run with extrinsics. Note that there are still issues with the waveform tapering, but I think we should merge anyway so that Jake and I are on the same page and don't duplicate effort.