Snapshots noetic and update ROS 2 distros building noetic bridge #817
Conversation
…pository Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
…fore retirement Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
…r images" This reverts commit d78d53f.
| ros-noetic-rospy-tutorials=0.10.2-1* \ | ||
| ros-noetic-ros-comm=1.17.4-1* \ | ||
| ros-noetic-roscpp-tutorials=0.10.3-1* \ | ||
| ros-noetic-rospy-tutorials=0.10.3-1* \ |
There was a problem hiding this comment.
Interesting that these aren't already set to the last package versions.
There was a problem hiding this comment.
Foxy has been EOL for a while, so the Noetic packages versions for building the bridge were not bumped since. Hopefully this will be ok with upstream to rebuild the images
| - 'ros/kilted/**' | ||
| - 'ros/humble/**' | ||
| # - 'ros/noetic/**' | ||
| - 'ros/noetic/**' |
There was a problem hiding this comment.
Do we need to add the EOL distros here as well for our CI to rebuild the OSRF tags?
We could also add them later also after the core tags have been merged upstream.
There was a problem hiding this comment.
tricky part is that the dockerfiles dont match the currently generated files (templates have evolved since those became EOL) so CI would be failing for those ditros. So not clear to me how we want to rebuild these images. I suspect we'll just have to rebuild them by hand and push them #818
tfoote
left a comment
tfoote
left a comment
There was a problem hiding this comment.
Generally this looks good. Let's land the templates change first and then we don't need the branch change.
docker/requirements.txt
Outdated
| ###### Requirements with Repo Specifiers ###### | ||
| # See https://pip.readthedocs.io/en/stable/reference/pip_install/#git | ||
| git+https://github.com/osrf/docker_templates.git@master#egg=docker_templates | ||
| git+https://github.com/osrf/docker_templates.git@follow-up-templates-114#egg=docker_templates |
There was a problem hiding this comment.
The templates change is approved. Let's revert this before merging
This reverts commit 15cf231.
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
mikaelarguedas
force-pushed
the
snapshots_noetic
branch
from
0449d89 to
ef6a883
Compare
|
Upstream PR: docker-library/official-images#19221 |
3 participants
This is generated from osrf/docker_templates#116
Now that the noetic final snapshot is available we can move ros noetic images to target the snapshot repository: #814
This will fix currently broken ROS Noetic docker images