Skip to content

Fix: Make handlerWrapper compatible with Node.js 24 #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shinzero999 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix: Make handlerWrapper compatible with Node.js 24 #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions lib/plugins/aws/custom-resources/resources/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,16 +73,30 @@ function getEnvironment(context) {
};
}

// function handlerWrapper(handler, PhysicalResourceId) {
// return async (event, context, callback) => {
// // extend the `event` object to include the PhysicalResourceId
// event = Object.assign({}, event, { PhysicalResourceId });
// return Promise.resolve(handler(event, context, callback))
// .then(
// (result) => response(event, context, 'SUCCESS', result),
// (error) => response(event, context, 'FAILED', {}, error)
// )
// .then((result) => callback(null, result), callback);
// };
// }
function handlerWrapper(handler, PhysicalResourceId) {
return async (event, context, callback) => {
// extend the `event` object to include the PhysicalResourceId
return async (event, context) => { // Removed callback parameter
event = Object.assign({}, event, { PhysicalResourceId });
return Promise.resolve(handler(event, context, callback))
.then(
(result) => response(event, context, 'SUCCESS', result),
(error) => response(event, context, 'FAILED', {}, error)
)
.then((result) => callback(null, result), callback);

try {
const result = await handler(event, context);
await response(event, context, 'SUCCESS', result);
return result;
} catch (error) {
await response(event, context, 'FAILED', {}, error);
throw error;
}
};
}

Expand Down