mz487: allow squashing pure copydependencies again#488
Draft
mz487: allow squashing pure copydependencies again#488
Conversation
Collaborator
Author
|
depends on #486 for it's integration tests |
4 tasks
mzihlmann
force-pushed
the
mz487-fix-squash-copydependency
branch
from
b28a583 to
6b2e539
Compare
mzihlmann
force-pushed
the
mz487-fix-squash-copydependency
branch
from
6b2e539 to
d06c24f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #487
Description
Our squashing logic has an optimization, we don't even attempt to squash if the stage is not used anyways. However, when we split the meaning of
stagesDependenciesandcopyDependenciesin #335, we did not update that optimization. As a result squashing was only applied to the former.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.