Don't erase elements if multiple subscriptions use them #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kilativ-dotcom
commented
Oct 15, 2024
kilativ-dotcom
commented
- Read PR documentation
- Update changelog
- Update documentation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
==========================================
+ Coverage 95.70% 95.76% +0.05%
==========================================
Files 237 237
Lines 26965 27315 +350
Branches 1863 1880 +17
==========================================
+ Hits 25808 26157 +349
- Misses 1157 1158 +1 🚀 New features to boost your workflow:
|
NikitaZotov
requested changes
Oct 17, 2024
Comment on lines
253
to
261
| sc_uint32 * count = (sc_uint32 *)sc_hash_table_get( | ||
| manager->emitted_erase_events, GUINT_TO_POINTER(SC_ADDR_LOCAL_TO_INT(connector_addr))); | ||
| if (count == null_ptr) | ||
| { | ||
| count = sc_mem_new(sc_uint32, 1); | ||
| *count = 0; | ||
| } | ||
| ++(*count); | ||
| sc_hash_table_insert(manager->emitted_erase_events, GUINT_TO_POINTER(SC_ADDR_LOCAL_TO_INT(connector_addr)), count); |
Member
There was a problem hiding this comment.
Suggested change
| sc_uint32 * count = (sc_uint32 *)sc_hash_table_get( | |
| manager->emitted_erase_events, GUINT_TO_POINTER(SC_ADDR_LOCAL_TO_INT(connector_addr))); | |
| if (count == null_ptr) | |
| { | |
| count = sc_mem_new(sc_uint32, 1); | |
| *count = 0; | |
| } | |
| ++(*count); | |
| sc_hash_table_insert(manager->emitted_erase_events, GUINT_TO_POINTER(SC_ADDR_LOCAL_TO_INT(connector_addr)), count); | |
| sc_uint32 count = (sc_uint32)(sc_uint64)sc_hash_table_get( | |
| manager->emitted_erase_events, GUINT_TO_POINTER(SC_ADDR_LOCAL_TO_INT(connector_addr))); | |
| ++count; | |
| sc_hash_table_insert(manager->emitted_erase_events, GUINT_TO_POINTER(SC_ADDR_LOCAL_TO_INT(connector_addr)), count); |
sc-memory/sc-memory/tests/sc-memory/units/events/test_sc_event.cpp
Outdated
Show resolved
Hide resolved
NikitaZotov
changed the title
NikitaZotov
requested changes
Nov 4, 2024
sc-memory/sc-memory/tests/sc-memory/units/agents/test_sc_specified_agents.cpp
Outdated
Show resolved
Hide resolved
sc-memory/sc-memory/tests/sc-memory/units/agents/test_sc_specified_agents.cpp
Outdated
Show resolved
Hide resolved
sc-memory/sc-memory/tests/sc-memory/units/agents/test_sc_specified_agents.cpp
Outdated
Show resolved
Hide resolved
sc-memory/sc-memory/tests/sc-memory/units/events/test_sc_event.cpp
Outdated
Show resolved
Hide resolved
sc-memory/sc-memory/tests/sc-memory/units/events/test_sc_event.cpp
Outdated
Show resolved
Hide resolved
NikitaZotov
requested changes
Nov 25, 2024
|
|
||
| sc_result _sc_storage_element_erase_with_incoming_outgoing_connectors( | ||
| sc_memory_context const * ctx, | ||
| sc_addr connector_chain_begin_addr, |
Member
Author
There was a problem hiding this comment.
chain is like sequence of connectors next connector of which cannot exist without previous(previous element is source/target of next connector)
sc-memory/sc-memory/tests/sc-memory/units/events/test_sc_event.cpp
Outdated
Show resolved
Hide resolved
sc-memory/sc-memory/tests/sc-memory/units/events/test_sc_event.cpp
Outdated
Show resolved
Hide resolved
sc-memory/sc-memory/tests/sc-memory/units/events/test_sc_event.cpp
Outdated
Show resolved
Hide resolved
NikitaZotov
added
bug
… event linked to subscription
…stency for agents responding to sc-events of erasing sc-elements
NikitaZotov
force-pushed
the
fix/erase_events
branch
from
c8eebff to
ad6d130
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.