forked from DavidDragonsage/FooocusPlus
-
Notifications
You must be signed in to change notification settings - Fork 1
[ADD] Update comfy to the last version, all features functionnal #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TristanValentin07
wants to merge
1
commit into
main
Choose a base branch
from
feat/Major-update-of-comfy-functionnal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
The diff you're trying to view is too large. We only load the first 3000 changed files.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
comfy/.ci/windows_amd_base_files/README_VERY_IMPORTANT.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| As of the time of writing this you need this preview driver for best results: | ||
| https://www.amd.com/en/resources/support-articles/release-notes/RN-AMDGPU-WINDOWS-PYTORCH-PREVIEW.html | ||
|
|
||
| HOW TO RUN: | ||
|
|
||
| If you have a AMD gpu: | ||
|
|
||
| run_amd_gpu.bat | ||
|
|
||
| If you have memory issues you can try disabling the smart memory management by running comfyui with: | ||
|
|
||
| run_amd_gpu_disable_smart_memory.bat | ||
|
|
||
| IF YOU GET A RED ERROR IN THE UI MAKE SURE YOU HAVE A MODEL/CHECKPOINT IN: ComfyUI\models\checkpoints | ||
|
|
||
| You can download the stable diffusion XL one from: https://huggingface.co/stabilityai/stable-diffusion-xl-base-1.0/blob/main/sd_xl_base_1.0_0.9vae.safetensors | ||
|
|
||
|
|
||
| RECOMMENDED WAY TO UPDATE: | ||
| To update the ComfyUI code: update\update_comfyui.bat | ||
|
|
||
|
|
||
| TO SHARE MODELS BETWEEN COMFYUI AND ANOTHER UI: | ||
| In the ComfyUI directory you will find a file: extra_model_paths.yaml.example | ||
| Rename this file to: extra_model_paths.yaml and edit it with your favorite text editor. | ||
|
|
||
|
|
File renamed without changes.
2 changes: 2 additions & 0 deletions
2
comfy/.ci/windows_amd_base_files/run_amd_gpu_disable_smart_memory.bat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| .\python_embeded\python.exe -s ComfyUI\main.py --windows-standalone-build --disable-smart-memory | ||
| pause |
This file was deleted.
Oops, something went wrong.
34 changes: 34 additions & 0 deletions
34
comfy/.ci/windows_nvidia_base_files/README_VERY_IMPORTANT.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| HOW TO RUN: | ||
|
|
||
| if you have a NVIDIA gpu: | ||
|
|
||
| run_nvidia_gpu.bat | ||
|
|
||
| if you want to enable the fast fp16 accumulation (faster for fp16 models with slightly less quality): | ||
|
|
||
| run_nvidia_gpu_fast_fp16_accumulation.bat | ||
|
|
||
|
|
||
| To run it in slow CPU mode: | ||
|
|
||
| run_cpu.bat | ||
|
|
||
|
|
||
|
|
||
| IF YOU GET A RED ERROR IN THE UI MAKE SURE YOU HAVE A MODEL/CHECKPOINT IN: ComfyUI\models\checkpoints | ||
|
|
||
| You can download the stable diffusion 1.5 one from: https://huggingface.co/Comfy-Org/stable-diffusion-v1-5-archive/blob/main/v1-5-pruned-emaonly-fp16.safetensors | ||
|
|
||
|
|
||
| RECOMMENDED WAY TO UPDATE: | ||
| To update the ComfyUI code: update\update_comfyui.bat | ||
|
|
||
|
|
||
|
|
||
| To update ComfyUI with the python dependencies, note that you should ONLY run this if you have issues with python dependencies. | ||
| update\update_comfyui_and_python_dependencies.bat | ||
|
|
||
|
|
||
| TO SHARE MODELS BETWEEN COMFYUI AND ANOTHER UI: | ||
| In the ComfyUI directory you will find a file: extra_model_paths.yaml.example | ||
| Rename this file to: extra_model_paths.yaml and edit it with your favorite text editor. |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| .\python_embeded\python.exe -s ComfyUI\main.py --windows-standalone-build | ||
| pause |
2 changes: 2 additions & 0 deletions
2
comfy/.ci/windows_nvidia_base_files/run_nvidia_gpu_fast_fp16_accumulation.bat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| .\python_embeded\python.exe -s ComfyUI\main.py --windows-standalone-build --fast fp16_accumulation | ||
| pause |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| /web/assets/** linguist-generated | ||
| /web/** linguist-vendored | ||
| comfy_api_nodes/apis/__init__.py linguist-generated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| name: Bug Report | ||
| description: "Something is broken inside of ComfyUI. (Do not use this if you're just having issues and need help, or if the issue relates to a custom node)" | ||
| labels: ["Potential Bug"] | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| Before submitting a **Bug Report**, please ensure the following: | ||
|
|
||
| - **1:** You are running the latest version of ComfyUI. | ||
| - **2:** You have looked at the existing bug reports and made sure this isn't already reported. | ||
| - **3:** You confirmed that the bug is not caused by a custom node. You can disable all custom nodes by passing | ||
| `--disable-all-custom-nodes` command line argument. | ||
| - **4:** This is an actual bug in ComfyUI, not just a support question. A bug is when you can specify exact | ||
| steps to replicate what went wrong and others will be able to repeat your steps and see the same issue happen. | ||
|
|
||
| If unsure, ask on the [ComfyUI Matrix Space](https://app.element.io/#/room/%23comfyui_space%3Amatrix.org) or the [Comfy Org Discord](https://discord.gg/comfyorg) first. | ||
| - type: checkboxes | ||
| id: custom-nodes-test | ||
| attributes: | ||
| label: Custom Node Testing | ||
| description: Please confirm you have tried to reproduce the issue with all custom nodes disabled. | ||
| options: | ||
| - label: I have tried disabling custom nodes and the issue persists (see [how to disable custom nodes](https://docs.comfy.org/troubleshooting/custom-node-issues#step-1%3A-test-with-all-custom-nodes-disabled) if you need help) | ||
| required: false | ||
| - type: textarea | ||
| attributes: | ||
| label: Expected Behavior | ||
| description: "What you expected to happen." | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| attributes: | ||
| label: Actual Behavior | ||
| description: "What actually happened. Please include a screenshot of the issue if possible." | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| attributes: | ||
| label: Steps to Reproduce | ||
| description: "Describe how to reproduce the issue. Please be sure to attach a workflow JSON or PNG, ideally one that doesn't require custom nodes to test. If the bug open happens when certain custom nodes are used, most likely that custom node is what has the bug rather than ComfyUI, in which case it should be reported to the node's author." | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| attributes: | ||
| label: Debug Logs | ||
| description: "Please copy the output from your terminal logs here." | ||
| render: powershell | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| attributes: | ||
| label: Other | ||
| description: "Any other additional information you think might be helpful." | ||
| validations: | ||
| required: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| blank_issues_enabled: true | ||
| contact_links: | ||
| - name: ComfyUI Frontend Issues | ||
| url: https://github.com/Comfy-Org/ComfyUI_frontend/issues | ||
| about: Issues related to the ComfyUI frontend (display issues, user interaction bugs), please go to the frontend repo to file the issue | ||
| - name: ComfyUI Matrix Space | ||
| url: https://app.element.io/#/room/%23comfyui_space%3Amatrix.org | ||
| about: The ComfyUI Matrix Space is available for support and general discussion related to ComfyUI (Matrix is like Discord but open source). | ||
| - name: Comfy Org Discord | ||
| url: https://discord.gg/comfyorg | ||
| about: The Comfy Org Discord is available for support and general discussion related to ComfyUI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| name: Feature Request | ||
| description: "You have an idea for something new you would like to see added to ComfyUI's core." | ||
| labels: [ "Feature" ] | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| Before submitting a **Feature Request**, please ensure the following: | ||
|
|
||
| **1:** You are running the latest version of ComfyUI. | ||
| **2:** You have looked to make sure there is not already a feature that does what you need, and there is not already a Feature Request listed for the same idea. | ||
| **3:** This is something that makes sense to add to ComfyUI Core, and wouldn't make more sense as a custom node. | ||
|
|
||
| If unsure, ask on the [ComfyUI Matrix Space](https://app.element.io/#/room/%23comfyui_space%3Amatrix.org) or the [Comfy Org Discord](https://discord.gg/comfyorg) first. | ||
| - type: textarea | ||
| attributes: | ||
| label: Feature Idea | ||
| description: "Describe the feature you want to see." | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| attributes: | ||
| label: Existing Solutions | ||
| description: "Please search through available custom nodes / extensions to see if there are existing custom solutions for this. If so, please link the options you found here as a reference." | ||
| validations: | ||
| required: false | ||
| - type: textarea | ||
| attributes: | ||
| label: Other | ||
| description: "Any other additional information you think might be helpful." | ||
| validations: | ||
| required: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| name: User Support | ||
| description: "Use this if you need help with something, or you're experiencing an issue." | ||
| labels: [ "User Support" ] | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| Before submitting a **User Report** issue, please ensure the following: | ||
|
|
||
| **1:** You are running the latest version of ComfyUI. | ||
| **2:** You have made an effort to find public answers to your question before asking here. In other words, you googled it first, and scrolled through recent help topics. | ||
|
|
||
| If unsure, ask on the [ComfyUI Matrix Space](https://app.element.io/#/room/%23comfyui_space%3Amatrix.org) or the [Comfy Org Discord](https://discord.gg/comfyorg) first. | ||
| - type: checkboxes | ||
| id: custom-nodes-test | ||
| attributes: | ||
| label: Custom Node Testing | ||
| description: Please confirm you have tried to reproduce the issue with all custom nodes disabled. | ||
| options: | ||
| - label: I have tried disabling custom nodes and the issue persists (see [how to disable custom nodes](https://docs.comfy.org/troubleshooting/custom-node-issues#step-1%3A-test-with-all-custom-nodes-disabled) if you need help) | ||
| required: false | ||
| - type: textarea | ||
| attributes: | ||
| label: Your question | ||
| description: "Post your question here. Please be as detailed as possible." | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| attributes: | ||
| label: Logs | ||
| description: "If your question relates to an issue you're experiencing, please go to `Server` -> `Logs` -> potentially set `View Type` to `Debug` as well, then copypaste all the text into here." | ||
| render: powershell | ||
| validations: | ||
| required: false | ||
| - type: textarea | ||
| attributes: | ||
| label: Other | ||
| description: "Any other additional information you think might be helpful." | ||
| validations: | ||
| required: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| name: Check for Windows Line Endings | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: ['*'] # Trigger on all pull requests to any branch | ||
|
|
||
| jobs: | ||
| check-line-endings: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 # Fetch all history to compare changes | ||
|
|
||
| - name: Check for Windows line endings (CRLF) | ||
| run: | | ||
| # Get the list of changed files in the PR | ||
| CHANGED_FILES=$(git diff --name-only ${{ github.event.pull_request.base.sha }}..${{ github.event.pull_request.head.sha }}) | ||
| # Flag to track if CRLF is found | ||
| CRLF_FOUND=false | ||
| # Loop through each changed file | ||
| for FILE in $CHANGED_FILES; do | ||
| # Check if the file exists and is a text file | ||
| if [ -f "$FILE" ] && file "$FILE" | grep -q "text"; then | ||
| # Check for CRLF line endings | ||
| if grep -UP '\r$' "$FILE"; then | ||
| echo "Error: Windows line endings (CRLF) detected in $FILE" | ||
| CRLF_FOUND=true | ||
| fi | ||
| fi | ||
| done | ||
| # Exit with error if CRLF was found | ||
| if [ "$CRLF_FOUND" = true ]; then | ||
| exit 1 | ||
| fi |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle missing origin/master more robustly; consider main fallback.
Current retry may still fail if origin is absent or branch is named main. Add guarded retries and abort cleanly; also make the status message branch-agnostic.
🤖 Prompt for AI Agents