Easier docker setup, less intervention #68
Open
Alt791350 wants to merge 2 commits intooutpoot:mainfrom
Open
Conversation
added 2 commits
July 2, 2025 17:00
fix: moved environment variables to a single .env file so docker compose can use these (at runtime and buildtime) fix(docker-compose): correct port forwarding based on .env variables fix(docker-compose): app not able to connect to database or redis since they are not in a/(the same) network fix(env): created a .env.example with working values that people can use immediatly to launch an instance (you should still change the values for an optimal experience) fix(Dockerfile:build-main): added build arguments so the env variables could be reused fix(Dockerfile): implemented moderation.ts and kept it as original as possible (not the scope of this commit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After trying it out I found some ways to improve the docker setup.
I haven't updated the README yet since their might be change requests.
In this setup you only need to:
.env.examplefile to a.envfiledocker compose builddocker compose up -dAnd that would be it.
This also fixes the missing
moderation.tsfor docker builds, building non-docker still works with the old method.I did also notice that the SHARP service might not boot correctly if the database hasn't initialised yet, especially if it has yet to import the
init.sqlbut after a restart of the SHARP service it seems to be fixed and working as intended.