Skip to content

Conversation

@chipp972
Copy link
Contributor

@chipp972 chipp972 commented Jan 7, 2026

ref: #MANAGER-20168

Description

Ticket Reference: #...

Additional Information

Copilot AI review requested due to automatic review settings January 7, 2026 15:13
@chipp972 chipp972 requested a review from a team as a code owner January 7, 2026 15:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds port range support to the Edge Network Firewall configuration, allowing users to specify port ranges (e.g., "80-90") in addition to single ports. The PR also removes the forced mitigation check for configuring the Edge Network Firewall and includes minor code quality improvements.

  • Adds UI support for entering port ranges with validation and helper tooltips
  • Implements logic to format port ranges into API-compatible formats (lt, gt, range)
  • Updates API types to accept both single ports and port ranges
  • Removes the forced mitigation prerequisite for Edge Network Firewall configuration

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
PortColumn.component.tsx Adds port range input validation, tooltip component, and updates input handling to accept hyphens
useCreateIpEdgeFirewallRule.ts Implements port range validation and formatting logic (formatPortValue, formatPortRangeValue)
useCreateIpEdgeFirewallRule.helpers.spec.ts Adds comprehensive tests for port range validation and formatting functions
ipEdgeFirewall.ts Updates API signature to support sourcePortRange and destinationPortRange parameters
IpActionsCell.tsx Removes forced mitigation check and related hook usage
IpActionsCell.spec.tsx Removes test case for forced mitigation scenario
Messages_fr_FR.json Updates column labels and adds tooltip text for port range format
SourceColumn.component.tsx Adds flex class for consistent layout
SequenceColumn.component.tsx Adds flex class for consistent layout
ProtocolColumn.component.tsx Adds flex class for consistent layout
ModeColumn.component.tsx Adds flex class for consistent layout
IpGameFirewallDisplay.tsx Minor code quality improvements (removes void keyword, uses !length instead of === 0)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

aderghamov
aderghamov previously approved these changes Jan 8, 2026
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Feb 4, 2026
@chipp972 chipp972 force-pushed the feat/20168-port-range-firewall branch from f3097c7 to ac4794c Compare February 10, 2026 16:18
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Feb 10, 2026
ref: #MANAGER-20168

Signed-off-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
Copilot AI review requested due to automatic review settings February 10, 2026 17:08
@chipp972 chipp972 force-pushed the feat/20168-port-range-firewall branch from ac4794c to d199818 Compare February 10, 2026 17:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants