feat(dedicated.cdn): service log-tail migration to l2c #21811

e-gautier · 2026-01-21T14:53:30Z

resolves: #CDN-1385

Description

This PR aims to replace the dedicated CDN service logs tab by the new l2c features, routes and components.

Copilot

Pull request overview

This PR migrates the dedicated CDN service logs tab from a legacy implementation to the new l2c (log-to-customer) framework. The migration replaces custom log-tailing functionality with reusable components from @ovh-ux/manager-log-to-customer.

Changes:

Replaced legacy log viewing UI with l2c components for live-tail and data-streams
Updated translation files to support new log descriptions and removed obsolete keys
Introduced new services, routing configurations, and controllers following l2c patterns

Reviewed changes

Copilot reviewed 35 out of 35 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/translations/*.json	Updated translation keys from legacy format to l2c-compatible descriptions
packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/logs.service.js	New service to fetch CDN log kinds from API
packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/logs.routing.js	New routing configuration for logs with l2c integration
packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/logs.module.js	Module setup importing l2c dependencies
packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/logs.html	Template using l2c live-tail component
packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/logs.controller.js	Controller managing l2c component bindings
packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/logs.constants.js	Constants for tracking, guide links, and log configuration
packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/live-tail/*	Live-tail component wrapping l2c functionality
packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/data-streams/*	Data streams listing and subscription components
packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/index.js	Updated module to integrate new l2c components
packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/cdn-dedicated-manage-logs.*	Removed legacy log controller, routes, and template

Comments suppressed due to low confidence (1)

packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/live-tail/live-tail.template.html:1

Corrected spelling of 'LOG_SUSBSCRIPTION' to 'LOG_SUBSCRIPTION'.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/logs.routing.js

packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/logs.html

packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/logs.constants.js

...dedicated/client/app/cdn/dedicated/manage/logs/data-streams/translations/Messages_de_DE.json

...manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/translations/Messages_de_DE.json

packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/data-streams/index.js

...ager/apps/dedicated/client/app/cdn/dedicated/manage/logs/data-streams/data-streams.module.js

Copilot

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-21T15:53:39Z

packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/logs.constants.js

+export const CDN_DEDICATED_LOGS_GUIDE = {
+  IE: {},
+  FR: {},
+};
+
+CDN_DEDICATED_LOGS_GUIDE.NL = CDN_DEDICATED_LOGS_GUIDE.IE;
+CDN_DEDICATED_LOGS_GUIDE.WE = CDN_DEDICATED_LOGS_GUIDE.IE;
+CDN_DEDICATED_LOGS_GUIDE.WW = CDN_DEDICATED_LOGS_GUIDE.IE;


CDN_DEDICATED_LOGS_GUIDE.IE and CDN_DEDICATED_LOGS_GUIDE.FR are referenced but never defined, causing these assignments to set all values to undefined. Define the base guide URLs for IE and FR subsidiaries before these assignments.

Copilot · 2026-01-21T15:53:40Z

...r/apps/dedicated/client/app/cdn/dedicated/manage/logs/data-streams/data-streams.component.js

+    apiVersion: '<',
+    trackingHits: '<',
+    logKinds: '<',
+    logSubscriptionApiData: '=',


Using two-way binding ('=') is an anti-pattern for components in AngularJS. This should use one-way binding ('<') instead, with data changes communicated through callbacks.

Suggested change

logSubscriptionApiData: '=',

logSubscriptionApiData: '<',

packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/logs.routing.js

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/live-tail/live-tail.template.html:1

This template file is identical to logs.html. The duplication should be eliminated by either removing this file if it's unused, or consolidating into a shared template if both are needed.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/live-tail/index.js

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

resolves: #CDN-1385 Signed-off-by: Etienne GAUTIER <etienne.gautier@ovhcloud.com>

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-10T16:16:28Z

packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/logs.routing.js

+    redirectTo,
+    resolve: {
+      breadcrumb: /* @ngInject */ ($translate) =>
+        $translate.instant('cdn_logs'),


The breadcrumb translation key was changed to cdn_logs, but the provided FR translations diff only adds cdn_logs_description and removes the previous cdn_tabs_logs key. This will likely display the raw key or an empty breadcrumb for fr_FR. Add a cdn_logs entry in the translations (for at least fr_FR) or update the breadcrumb to use an existing key.

Suggested change

$translate.instant('cdn_logs'),

$translate.instant('cdn_logs_description'),

Copilot · 2026-02-10T16:16:29Z

packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/logs.service.js

+  getLogKinds() {
+    return this.$http.get('/cdn/dedicated/log/kind').then(({ data }) => data);


This endpoint doesn’t include the dedicated CDN productId/serviceName, while the other log endpoints in routing are scoped under /cdn/dedicated/${productId}/log/.... If the API is service-scoped (which the other URLs strongly suggest), this call will hit the wrong route (or 404) and make the logs page redirect away due to empty kinds. Consider passing productId into getLogKinds(productId) (or building the URL from the same base) so it targets /cdn/dedicated/${productId}/log/kind (or the correct service-scoped path).

Suggested change

getLogKinds() {

return this.$http.get('/cdn/dedicated/log/kind').then(({ data }) => data);

getLogKinds(productId) {

return this.$http

.get(`/cdn/dedicated/${productId}/log/kind`)

.then(({ data }) => data);

Copilot · 2026-02-10T16:16:29Z

packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/data-streams/index.js

+import routing from './data-streams.routing';
+import controller from './data-streams.controller';
+
+const moduleName = 'cdnDedicatedLogsDataStreams';
+
+angular
+  .module(moduleName, [
+    uiRouter,
+    'ngTranslateAsyncLoader',
+    'oui',
+    'pascalprecht.translate',
+    ovhManagerLogToCustomer,
+  ])
+  .controller('CdnDedicatedLogsDataStreamsController', controller)
+  .config(routing)
+  .run(/* @ngTranslationsInject:json ./translations */);


A data-streams.component.js file is added in this PR, but this module doesn’t import/register it (no .component(...)). Either wire the component into the module (import it and register it) or remove the unused component file to avoid dead code and confusion about which template/controller is actually used.

e-gautier requested a review from a team as a code owner January 21, 2026 14:53

e-gautier requested review from Copilot, mhelhali-soufien and qpavy January 21, 2026 14:53

Copilot AI reviewed Jan 21, 2026

View reviewed changes

e-gautier force-pushed the feat/egautier/cdn-l2c-tail branch 3 times, most recently from 11d99ae to 63ffcc3 Compare January 21, 2026 15:12

github-actions bot added universe-bare-metal-cloud translation required feature New feature labels Jan 21, 2026

darsene reviewed Jan 21, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 21, 2026 15:52

e-gautier force-pushed the feat/egautier/cdn-l2c-tail branch 2 times, most recently from d737d23 to dcb7f05 Compare January 21, 2026 15:53

Copilot AI reviewed Jan 21, 2026

View reviewed changes

e-gautier force-pushed the feat/egautier/cdn-l2c-tail branch from dcb7f05 to e418e5f Compare January 21, 2026 16:00

darsene reviewed Jan 21, 2026

View reviewed changes

packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/logs.routing.js Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings January 22, 2026 08:46

e-gautier force-pushed the feat/egautier/cdn-l2c-tail branch from e418e5f to 2002384 Compare January 22, 2026 08:46

Copilot AI reviewed Jan 22, 2026

View reviewed changes

packages/manager/apps/dedicated/client/app/cdn/dedicated/manage/logs/live-tail/index.js Show resolved Hide resolved

e-gautier force-pushed the feat/egautier/cdn-l2c-tail branch from 2002384 to 1baf1ae Compare January 22, 2026 08:56

MehdiZaghouani previously approved these changes Jan 22, 2026

View reviewed changes

darsene previously approved these changes Jan 27, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings February 10, 2026 15:03

antleblanc dismissed stale reviews from darsene and MehdiZaghouani via 0af58b9 February 10, 2026 15:03

Copilot AI reviewed Feb 10, 2026

View reviewed changes

e-gautier removed the translation required label Feb 10, 2026

feat(dedicated.cdn): service log-tail migration to l2c

55bc246

resolves: #CDN-1385 Signed-off-by: Etienne GAUTIER <etienne.gautier@ovhcloud.com>

e-gautier force-pushed the feat/egautier/cdn-l2c-tail branch from 0af58b9 to de3590a Compare February 10, 2026 15:56

github-actions bot added the translation required label Feb 10, 2026

Copilot AI review requested due to automatic review settings February 10, 2026 16:14

e-gautier force-pushed the feat/egautier/cdn-l2c-tail branch from de3590a to 55bc246 Compare February 10, 2026 16:14

e-gautier removed the translation required label Feb 10, 2026

Copilot AI reviewed Feb 10, 2026

View reviewed changes

	$translate.instant('cdn_logs'),
	$translate.instant('cdn_logs_description'),

		getLogKinds() {
		return this.$http.get('/cdn/dedicated/log/kind').then(({ data }) => data);

feat(dedicated.cdn): service log-tail migration to l2c #21811

Are you sure you want to change the base?

feat(dedicated.cdn): service log-tail migration to l2c #21811

Uh oh!

Conversation

e-gautier commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

e-gautier commented Jan 21, 2026 •

edited

Loading