feat(zimbra): handle action buttons in services datagrid #22177
+260
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amine-daoussi
requested review from
atefzed,
Copilot and
ghyenne
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
Adds an action menu to each row in the Zimbra Services datagrid and introduces a dedicated email account settings route to support navigation from those actions.
Changes:
- Adds a new
settingsroute forEmailAccountSettingsPagewith tracking + breadcrumb metadata. - Adds an action-menu column to the Services datagrid.
- Introduces
ActionButtonServicecomponent and an initial unit test for menu items.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| packages/manager/apps/zimbra/src/routes/routes.tsx | Adds a settings route used by action-menu navigation + tracking metadata. |
| packages/manager/apps/zimbra/src/pages/dashboard/services/Services.page.tsx | Adds a new datagrid column rendering the per-row action menu. |
| packages/manager/apps/zimbra/src/pages/dashboard/services/ActionButton.component.tsx | Implements the per-row action menu and navigation/tracking handlers. |
| packages/manager/apps/zimbra/src/pages/dashboard/services/ActionButton.spec.tsx | Adds a unit test asserting displayed menu item labels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/manager/apps/zimbra/src/pages/dashboard/services/Services.page.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/zimbra/src/pages/dashboard/services/Services.page.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/zimbra/src/pages/dashboard/services/Services.page.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/zimbra/src/pages/dashboard/services/ActionButton.spec.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/zimbra/src/pages/dashboard/services/ActionButton.component.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/zimbra/src/pages/dashboard/services/ActionButton.component.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/zimbra/src/pages/dashboard/services/ActionButton.component.tsx
Outdated
Show resolved
Hide resolved
amine-daoussi
force-pushed
the
feat/PRDCOL-336
branch
from
6939222 to
583b624
Compare
amine-daoussi
force-pushed
the
feat/PRDCOL-336
branch
from
583b624 to
38fe2e4
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/manager/apps/zimbra/src/pages/dashboard/services/ActionButton.component.tsx
Show resolved
Hide resolved
packages/manager/apps/zimbra/src/pages/dashboard/services/ActionButton.component.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/zimbra/src/pages/dashboard/services/ActionButton.spec.tsx
Outdated
Show resolved
Hide resolved
atefzed
reviewed
Feb 10, 2026
packages/manager/apps/zimbra/src/pages/dashboard/services/ActionButton.component.tsx
Outdated
Show resolved
Hide resolved
atefzed
reviewed
Feb 10, 2026
packages/manager/apps/zimbra/src/pages/dashboard/services/ActionButton.spec.tsx
Outdated
Show resolved
Hide resolved
amine-daoussi
force-pushed
the
feat/PRDCOL-336
branch
from
38fe2e4 to
cb1a599
Compare
amine-daoussi
force-pushed
the
feat/PRDCOL-336
branch
from
cb1a599 to
6b7d4ba
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/manager/apps/zimbra/src/pages/dashboard/services/ActionButton.component.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/zimbra/src/pages/dashboard/services/ActionButton.spec.tsx
Show resolved
Hide resolved
atefzed
reviewed
Feb 10, 2026
packages/manager/apps/zimbra/src/pages/dashboard/services/ActionButton.component.tsx
Outdated
Show resolved
Hide resolved
atefzed
reviewed
Feb 10, 2026
packages/manager/apps/zimbra/src/pages/dashboard/services/ActionButton.component.tsx
Outdated
Show resolved
Hide resolved
ref: #PRDCOL-336 Signed-off-by: amine-daoussi <mohamed-amine.daoussi.ext@corp.ovh.com>
amine-daoussi
force-pushed
the
feat/PRDCOL-336
branch
from
6b7d4ba to
ea5345f
Compare
atefzed
reviewed
Feb 10, 2026
packages/manager/apps/zimbra/src/pages/dashboard/services/ActionButton.component.tsx
Show resolved
Hide resolved
atefzed
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #PRDCOL-336
Description
In Zimbra > Services: