Refacto/backup agent tanstack query #22178
Open
+1,229
−1,275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibs245
requested review from
AkdM,
Emiri-i,
Masta2000,
Taelar,
Tsiorifamonjena,
ZyaCon,
aTurmo,
aboungnaseng-ovhcloud,
abullet33,
anooparveti,
fredericvilcot,
helabenkhalfallah,
jperchoc and
lolottetheclash
and removed request for
a team
tibs245
changed the base branch from
release/backup-project-backup-agent
to
master
Signed-off-by: tibs245 <thibault.barske@kolombo.xyz>
tibs245
force-pushed
the
refacto/backup-agent-tanstack-query
branch
3 times, most recently
from
5282cc2 to
ca356e6
Compare
pauldkn
previously approved these changes
Feb 10, 2026
Contributor
There was a problem hiding this comment.
I really like the data/queries folder — it provides a single source of truth for all fetches, and I find calling vaultsQueries.all or vaultQueries.detail is more readable
The only part that feels like it adds complexity is everything around withClient(), but that's very specific to this module and the associated business rules. Without the need to retrieve backupServiceId from the cache, it would probably be cleaner (as in some other projects)
Overall, I think this is a better approach than before 👍
Signed-off-by: tibs245 <thibault.barske@kolombo.xyz>
tibs245
force-pushed
the
refacto/backup-agent-tanstack-query
branch
from
ca356e6 to
d10b473
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket Reference: #...
Additional Information